[PATCH 1/2] dt-bindings: spi: Update clocks property for ARM pl022

[PATCH 1/2] dt-bindings: spi: Update clocks property for ARM pl022

[Kuldeep Singh]

Add missing minItems property to clocks in ARM pl022 bindings.

This helps in resolving below warnings:
clocks: [[4]] is too short
clock-names: ['apb_pclk'] is too short

Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
 Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 6d633728fc2b..7d36e15db5b3 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -34,6 +34,7 @@ properties:
     maxItems: 1
 
   clocks:
+    minItems: 1
     maxItems: 2
 
   clock-names:
-- 
2.25.1

[PATCH 2/2] dt-bindings: spi: Update clock-names property for ARM pl022

[Kuldeep Singh]

Pl022 clock-names can be one of following:
['apb_pclk'] or ['sspclk', 'apb_pclk']

The current schema refers to second case only. Make necessary changes to
incorporate both the cases and resolve below dtc warnings:
clock-names: 'apb_pclk' is not one of ['sspclk']

Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
 Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 7d36e15db5b3..6cfab948624e 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -38,11 +38,13 @@ properties:
     maxItems: 2
 
   clock-names:
-    items:
+    oneOf:
       - enum:
-          - SSPCLK
-          - sspclk
-      - const: apb_pclk
+          - apb_pclk
+      - items:
+          - enum:
+              - sspclk
+          - const: apb_pclk
 
   pl022,autosuspend-delay:
     description: delay in ms following transfer completion before the
-- 
2.25.1

Re: [PATCH 1/2] dt-bindings: spi: Update clocks property for ARM pl022

[Krzysztof Kozlowski]

On 07/03/2022 21:37, Kuldeep Singh wrote:
> Add missing minItems property to clocks in ARM pl022 bindings.
> 
> This helps in resolving below warnings:
> clocks: [[4]] is too short
> clock-names: ['apb_pclk'] is too short
> 
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

I saw these series in the past... please do not send the same version again.

You need to version your series (git format-patch -v2 -2) and add
changelog in cover letter (or for small patches after '---' in commits).

How did you resolve the comments that the DTS might be wrong? It looks
like you simply resent it...


Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: spi: Update clocks property for ARM pl022

[Kuldeep Singh]

On Mon, Mar 07, 2022 at 10:55:52PM +0100, Krzysztof Kozlowski wrote:
> On 07/03/2022 21:37, Kuldeep Singh wrote:
> > Add missing minItems property to clocks in ARM pl022 bindings.
> > 
> > This helps in resolving below warnings:
> > clocks: [[4]] is too short
> > clock-names: ['apb_pclk'] is too short
> > 
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> I saw these series in the past... please do not send the same version again.
> 
> You need to version your series (git format-patch -v2 -2) and add
> changelog in cover letter (or for small patches after '---' in commits).

Ahh no. I completely missed out updating series number before sending.
Actually I have been struggling to get mutt client setup with gmail
account to send replies but it doesn't seem to work properly. Gmail
labels has been hardest part. In between these hurdles, I rolled out
patches and missed out this important thing.

Kindly consider these 2 patches as deprecated.

> 
> How did you resolve the comments that the DTS might be wrong? It looks
> like you simply resent it...

Few broadcom boards(stingray and ns2) require DT updation for which I
sent patches and received Florain's blessings. Those patches are now
available in github.com/Broadcom/stblinux, devicetree-arm64

There are several other updations(in realview, versatile etc.) required
which I couldn't mention before as they are part of different tree.