From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>
Subject: [PATCH v1 1/4] spidev: Do not use atomic bit operations when allocating minor
Date: Wed, 23 Mar 2022 16:02:12 +0200 [thread overview]
Message-ID: <20220323140215.2568-1-andriy.shevchenko@linux.intel.com> (raw)
There is no need to use atomic bit operations when allocating a minor
number since it's done under a mutex. Moreover, one of the operations
that is in use is non-atomic anyway.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spidev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 53a551714265..daeaa4a30290 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -795,7 +795,7 @@ static int spidev_probe(struct spi_device *spi)
status = -ENODEV;
}
if (status == 0) {
- set_bit(minor, minors);
+ __set_bit(minor, minors);
list_add(&spidev->device_entry, &device_list);
}
mutex_unlock(&device_list_lock);
@@ -823,7 +823,7 @@ static void spidev_remove(struct spi_device *spi)
list_del(&spidev->device_entry);
device_destroy(spidev_class, spidev->devt);
- clear_bit(MINOR(spidev->devt), minors);
+ __clear_bit(MINOR(spidev->devt), minors);
if (spidev->users == 0)
kfree(spidev);
mutex_unlock(&device_list_lock);
--
2.35.1
next reply other threads:[~2022-03-23 14:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 14:02 Andy Shevchenko [this message]
2022-03-23 14:02 ` [PATCH v1 2/4] spidev: Convert BUILD_BUG_ON() to static_assert() Andy Shevchenko
2022-03-23 14:02 ` [PATCH v1 3/4] spidev: Replace ACPI specific code by device_get_match_data() Andy Shevchenko
2022-03-23 14:02 ` [PATCH v1 4/4] spidev: Replace OF specific code by device property API Andy Shevchenko
2022-03-23 16:39 ` [PATCH v1 1/4] spidev: Do not use atomic bit operations when allocating minor Mark Brown
2022-03-23 17:22 ` Andy Shevchenko
2022-03-23 19:06 ` Mark Brown
2022-03-24 9:24 ` Andy Shevchenko
2022-03-24 14:28 ` Mark Brown
2022-03-25 11:09 ` Andy Shevchenko
2022-03-26 1:29 ` Yury Norov
2022-03-25 12:44 ` Andy Shevchenko
2022-03-25 13:26 ` Mark Brown
2022-03-25 13:44 ` Andy Shevchenko
2022-04-05 9:32 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323140215.2568-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).