From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: mxic: Fix an error handling path in mxic_spi_probe()
Date: Mon, 4 Apr 2022 09:41:02 +0200 [thread overview]
Message-ID: <20220404094102.48edaab5@xps13> (raw)
In-Reply-To: <09c81f751241f6ec0bac7a48d4ec814a742e0d17.1648980664.git.christophe.jaillet@wanadoo.fr>
Hi Christophe,
christophe.jaillet@wanadoo.fr wrote on Sun, 3 Apr 2022 12:11:13 +0200:
> If spi_register_master() fails, we must undo a previous
> mxic_spi_mem_ecc_probe() call, as already done in the remove function.
>
> Fixes: 00360ebae483 ("spi: mxic: Add support for pipelined ECC operations")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/spi/spi-mxic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-mxic.c b/drivers/spi/spi-mxic.c
> index 55c092069301..65be8e085ab8 100644
> --- a/drivers/spi/spi-mxic.c
> +++ b/drivers/spi/spi-mxic.c
> @@ -813,6 +813,7 @@ static int mxic_spi_probe(struct platform_device *pdev)
> if (ret) {
> dev_err(&pdev->dev, "spi_register_master failed\n");
> pm_runtime_disable(&pdev->dev);
> + mxic_spi_mem_ecc_remove(mxic);
I missed it, thanks!
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cheers,
Miquèl
next prev parent reply other threads:[~2022-04-04 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 10:11 [PATCH] spi: mxic: Fix an error handling path in mxic_spi_probe() Christophe JAILLET
2022-04-04 7:41 ` Miquel Raynal [this message]
2022-04-05 9:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404094102.48edaab5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).