[PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[Rob Herring]

The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples.

'spi-max-frequency' is supposed to be a per SPI peripheral device property,
not a SPI controller property, so drop it.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml | 1 -
 Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
index ece261b8e963..7326c0a28d16 100644
--- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
@@ -47,6 +47,5 @@ examples:
         clocks = <&clkcfg CLK_SPI0>;
         interrupt-parent = <&plic>;
         interrupts = <54>;
-        spi-max-frequency = <25000000>;
     };
 ...
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
index e2c7b934c50d..78ceb9d67754 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
@@ -110,7 +110,6 @@ examples:
         pinctrl-names = "default";
         pinctrl-0 = <&qup_spi1_default>;
         interrupts = <GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>;
-        spi-max-frequency = <50000000>;
         #address-cells = <1>;
         #size-cells = <0>;
     };
-- 
2.34.1

Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[Krzysztof Kozlowski]

On 26/05/2022 03:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
> not a SPI controller property, so drop it.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[Conor.Dooley]

On 26/05/2022 02:41, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
> not a SPI controller property, so drop it.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

As this property is in the mpfs devicetree & I'll need to fix it, is this
patch targeted at 5.19? (I assume given the window is open and there's no
fixes tag that it isn't).

As an aside, I meant to send the driver once the merge window closes, so
thanks for spotting a problem with the driver before I even sent it :)

Thanks,
Conor.

> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml | 1 -
>   Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index ece261b8e963..7326c0a28d16 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -47,6 +47,5 @@ examples:
>           clocks = <&clkcfg CLK_SPI0>;
>           interrupt-parent = <&plic>;
>           interrupts = <54>;
> -        spi-max-frequency = <25000000>;
>       };
>   ...
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index e2c7b934c50d..78ceb9d67754 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -110,7 +110,6 @@ examples:
>           pinctrl-names = "default";
>           pinctrl-0 = <&qup_spi1_default>;
>           interrupts = <GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>;
> -        spi-max-frequency = <50000000>;
>           #address-cells = <1>;
>           #size-cells = <0>;
>       };
> --
> 2.34.1
> 

Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[Rob Herring]

On Thu, May 26, 2022 at 06:52:23AM +0000, Conor.Dooley@microchip.com wrote:
> On 26/05/2022 02:41, Rob Herring wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > catch some cases where there's a $ref to another schema. A fix is pending,
> > but results in new warnings in examples.
> > 
> > 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
> > not a SPI controller property, so drop it.
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> 
> As this property is in the mpfs devicetree & I'll need to fix it, is this
> patch targeted at 5.19? (I assume given the window is open and there's no
> fixes tag that it isn't).

5.18 ideally because warnings are going to appear when I push the 
dtschema fix for 'unevaluatedProperties'.

Rob

Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[Conor.Dooley]

On 26/05/2022 15:01, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, May 26, 2022 at 06:52:23AM +0000, Conor.Dooley@microchip.com wrote:
>> On 26/05/2022 02:41, Rob Herring wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> The 'unevaluatedProperties' schema checks is not fully working and doesn't
>>> catch some cases where there's a $ref to another schema. A fix is pending,
>>> but results in new warnings in examples.
>>>
>>> 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
>>> not a SPI controller property, so drop it.
>>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> As this property is in the mpfs devicetree & I'll need to fix it, is this
>> patch targeted at 5.19? (I assume given the window is open and there's no
>> fixes tag that it isn't).
> 
> 5.18 ideally because warnings are going to appear when I push the

18? That a typo or am I missing something? Either way, will send the dt
fix shortly.
Thanks,
Conor.

> dtschema fix for 'unevaluatedProperties'.
> 
> Rob

Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

[Mark Brown]

On Wed, 25 May 2022 20:41:41 -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
> not a SPI controller property, so drop it.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: dt-bindings: Fix unevaluatedProperties warnings in examples
      commit: 6aa27071e4354c351d98e345fc888b70f335f185

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark