From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach
Date: Tue, 7 Jun 2022 23:20:58 +0300 [thread overview]
Message-ID: <20220607202058.8304-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220607202058.8304-1-andriy.shevchenko@linux.intel.com>
We have already a helper to get the first child device, use it and
drop custom approach.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index ea09d1b42bf6..87dc8773108b 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2613,11 +2613,6 @@ int spi_slave_abort(struct spi_device *spi)
}
EXPORT_SYMBOL_GPL(spi_slave_abort);
-static int match_true(struct device *dev, void *data)
-{
- return 1;
-}
-
static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
@@ -2625,7 +2620,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
dev);
struct device *child;
- child = device_find_child(&ctlr->dev, NULL, match_true);
+ child = device_find_first_child(&ctlr->dev);
return sprintf(buf, "%s\n",
child ? to_spi_device(child)->modalias : NULL);
}
@@ -2644,7 +2639,7 @@ static ssize_t slave_store(struct device *dev, struct device_attribute *attr,
if (rc != 1 || !name[0])
return -EINVAL;
- child = device_find_child(&ctlr->dev, NULL, match_true);
+ child = device_find_first_child(&ctlr->dev);
if (child) {
/* Remove registered slave */
device_unregister(child);
--
2.35.1
next prev parent reply other threads:[~2022-06-08 0:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 20:20 [PATCH v1 1/2] driver core: Introduce device_find_first_child() helper Andy Shevchenko
2022-06-07 20:20 ` Andy Shevchenko [this message]
2022-06-08 11:30 ` [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach Rafael J. Wysocki
2022-06-08 11:36 ` Greg Kroah-Hartman
2022-06-08 11:49 ` Andy Shevchenko
2022-06-08 12:03 ` Greg Kroah-Hartman
2022-06-08 12:23 ` Andy Shevchenko
2022-06-08 11:29 ` [PATCH v1 1/2] driver core: Introduce device_find_first_child() helper Rafael J. Wysocki
2022-06-08 11:53 ` Andy Shevchenko
2022-06-08 12:04 ` Greg Kroah-Hartman
2022-06-08 12:15 ` Rafael J. Wysocki
2022-06-08 12:23 ` Greg Kroah-Hartman
2022-06-08 13:32 ` Rafael J. Wysocki
2022-06-08 12:19 ` Rafael J. Wysocki
2022-06-08 11:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607202058.8304-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).