From: Serge Semin <fancer.lancer@gmail.com>
To: nandhini.srikandan@intel.com
Cc: broonie@kernel.org, robh+dt@kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, mgross@linux.intel.com,
kris.pan@intel.com, kenchappa.demakkanavar@intel.com,
furong.zhou@intel.com, mallikarjunappa.sangannavar@intel.com,
mahesh.r.vaidya@intel.com, rashmi.a@intel.com
Subject: Re: [PATCH v5 1/4] spi: dw: Fix IP-core versions macro
Date: Thu, 7 Jul 2022 16:29:12 +0300 [thread overview]
Message-ID: <20220707132912.j26r4ziai4a5g2a4@mobilestation> (raw)
In-Reply-To: <20220706042039.5763-2-nandhini.srikandan@intel.com>
Hi Nandhini
On Wed, Jul 06, 2022 at 12:20:36PM +0800, nandhini.srikandan@intel.com wrote:
> From: Nandhini Srikandan <nandhini.srikandan@intel.com>
>
> Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions interface")
> Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com>
As Mark already noted each patch is supposed to have a changelog [1].
Please add a detailed explanation of the problem above the tags
block [1].
[1] "Patch formatting and changelogs" Documentation/process/5.Posting.rst
-Sergey
> ---
> drivers/spi/spi-dw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
> index d5ee5130601e..79d853f6d192 100644
> --- a/drivers/spi/spi-dw.h
> +++ b/drivers/spi/spi-dw.h
> @@ -23,7 +23,7 @@
> ((_dws)->ip == DW_ ## _ip ## _ID)
>
> #define __dw_spi_ver_cmp(_dws, _ip, _ver, _op) \
> - (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ver)
> + (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ ## _ver)
>
> #define dw_spi_ver_is(_dws, _ip, _ver) __dw_spi_ver_cmp(_dws, _ip, _ver, ==)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-07-07 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 4:20 [PATCH v5 0/4] Add support for Intel Thunder Bay SPI controller nandhini.srikandan
2022-07-06 4:20 ` [PATCH v5 1/4] spi: dw: Fix IP-core versions macro nandhini.srikandan
2022-07-06 11:58 ` Mark Brown
2022-07-06 14:56 ` Srikandan, Nandhini
2022-07-06 14:59 ` Mark Brown
2022-07-07 13:29 ` Serge Semin [this message]
2022-07-06 4:20 ` [PATCH v5 2/4] dt-bindings: spi: Add bindings for Intel Thunder Bay SoC nandhini.srikandan
2022-07-06 14:48 ` Rob Herring
2022-07-07 13:22 ` Serge Semin
2022-07-06 4:20 ` [PATCH v5 3/4] spi: dw: Add support for master mode selection for DWC SSI controller nandhini.srikandan
2022-07-07 13:32 ` Serge Semin
2022-07-06 4:20 ` [PATCH v5 4/4] spi: dw: Add support for Intel Thunder Bay SPI controller nandhini.srikandan
2022-07-07 13:34 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707132912.j26r4ziai4a5g2a4@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=furong.zhou@intel.com \
--cc=kenchappa.demakkanavar@intel.com \
--cc=kris.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mahesh.r.vaidya@intel.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=nandhini.srikandan@intel.com \
--cc=rashmi.a@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).