From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Cc: <broonie@kernel.org>, <sanju.mehta@amd.com>,
<chin-ting_kuo@aspeedtech.com>, <clg@kaod.org>,
<kdasu.kdev@gmail.com>, <f.fainelli@gmail.com>,
<rjui@broadcom.com>, <sbranden@broadcom.com>,
<eajames@linux.ibm.com>, <olteanv@gmail.com>, <han.xu@nxp.com>,
<john.garry@huawei.com>, <shawnguo@kernel.org>,
<s.hauer@pengutronix.de>, <narmstrong@baylibre.com>,
<khilman@baylibre.com>, <matthias.bgg@gmail.com>,
<haibo.chen@nxp.com>, <linus.walleij@linaro.org>,
<daniel@zonque.org>, <haojian.zhuang@gmail.com>,
<robert.jarzmik@free.fr>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <heiko@sntech.de>,
<krzysztof.kozlowski@linaro.org>, <andi@etezian.org>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
<wens@csie.org>, <jernej.skrabec@gmail.com>,
<samuel@sholland.org>, <masahisa.kojima@linaro.org>,
<jaswinder.singh@linaro.org>, <rostedt@goodmis.org>,
<mingo@redhat.com>, <l.stelmach@samsung.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <alex.aring@gmail.com>,
<stefan@datenfreihafen.org>, <kvalo@kernel.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<jic23@kernel.org>, <tudor.ambarus@microchip.com>,
<pratyush@kernel.org>, <git@amd.com>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <joel@jms.id.au>,
<andrew@aj.id.au>, <radu_nicolae.pirea@upb.ro>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<claudiu.beznea@microchip.com>,
<bcm-kernel-feedback-list@broadcom.com>,
<fancer.lancer@gmail.com>, <kernel@pengutronix.de>,
<festevam@gmail.com>, <linux-imx@nxp.com>, <jbrunet@baylibre.com>,
<martin.blumenstingl@googlemail.com>, <avifishman70@gmail.com>,
<tmaimon77@gmail.com>, <tali.perry1@gmail.com>,
<venture@google.com>, <yuenn@google.com>,
<benjaminfair@google.com>, <yogeshgaur.83@gmail.com>,
<konrad.dybcio@somainline.org>, <alim.akhtar@samsung.com>,
<ldewangan@nvidia.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <michal.simek@amd.com>,
<linux-aspeed@lists.ozlabs.org>, <openbmc@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-sunxi@lists.linux.dev>, <linux-tegra@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wpan@vger.kernel.org>,
<libertas-dev@lists.infradead.org>,
<linux-wireless@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<linux-iio@vger.kernel.org>, <michael@walle.cc>,
<akumarma@amd.com>, <amitrkcian2002@gmail.com>
Subject: Re: [PATCH 05/10] iio: imu: Replace spi->chip_select references to spi->chip_select[0]
Date: Mon, 17 Oct 2022 14:32:02 +0100 [thread overview]
Message-ID: <20221017143202.00003b1d@huawei.com> (raw)
In-Reply-To: <20221017121249.19061-6-amit.kumar-mahapatra@amd.com>
On Mon, 17 Oct 2022 17:42:44 +0530
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com> wrote:
> For adding multi CS support & to prevent any existing driver from
> breaking, replaced all spi->chip_select references to spi->chip_slect[0].
>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Hmm. No particular reason why that print should exist at all.
The warning above it covers the case where there is a mismatch
in IDs so this adds nothing useful.
So patch is fine, but I'd be equally happy with just dropping the
print.
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/imu/adis16400.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c
> index 17bb0c40a149..aa7bfcee3510 100644
> --- a/drivers/iio/imu/adis16400.c
> +++ b/drivers/iio/imu/adis16400.c
> @@ -466,7 +466,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev)
>
> dev_info(&indio_dev->dev, "%s: prod_id 0x%04x at CS%d (irq %d)\n",
> indio_dev->name, prod_id,
> - st->adis.spi->chip_select, st->adis.spi->irq);
> + st->adis.spi->chip_select[0], st->adis.spi->irq);
> }
> /* use high spi speed if possible */
> if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) {
next prev parent reply other threads:[~2022-10-17 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 12:12 [PATCH 00/10] spi: Add support for stacked/parallel memories Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 01/10] spi: Add stacked memories support in SPI core Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 02/10] spi: Replace all spi->chip_select & spi->cs_gpiod references with array Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 03/10] net: Replace spi->chip_select references to spi->chip_select[0] Amit Kumar Mahapatra
2022-10-17 13:04 ` Lars-Peter Clausen
2022-10-17 12:12 ` [PATCH 04/10] mtd: devices: " Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 05/10] iio: imu: " Amit Kumar Mahapatra
2022-10-17 13:32 ` Jonathan Cameron [this message]
2022-10-17 12:12 ` [PATCH 06/10] mtd: spi-nor: Add stacked memories support in spi-nor Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 07/10] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 08/10] spi: Add parallel memories support in SPI core Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 09/10] mtd: spi-nor: Add parallel memories support in spi-nor Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 10/10] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver Amit Kumar Mahapatra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017143202.00003b1d@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=agross@kernel.org \
--cc=akumarma@amd.com \
--cc=alex.aring@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=amit.kumar-mahapatra@amd.com \
--cc=amitrkcian2002@gmail.com \
--cc=andi@etezian.org \
--cc=andrew@aj.id.au \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=claudiu.beznea@microchip.com \
--cc=clg@kaod.org \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=eajames@linux.ibm.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=festevam@gmail.com \
--cc=git@amd.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=haojian.zhuang@gmail.com \
--cc=heiko@sntech.de \
--cc=jaswinder.singh@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=kdasu.kdev@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=masahisa.kojima@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael@walle.cc \
--cc=michal.simek@amd.com \
--cc=mingo@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=pratyush@kernel.org \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard@nod.at \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sanju.mehta@amd.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=tali.perry1@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=tudor.ambarus@microchip.com \
--cc=venture@google.com \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
--cc=yogeshgaur.83@gmail.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).