linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Lima <mauro.lima@eclypsium.com>
To: broonie@kernel.org
Cc: mika.westerberg@linux.intel.com, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Mauro Lima <mauro.lima@eclypsium.com>
Subject: [PATCH 0/2] intel-spi: Split hardware and software sequencing
Date: Thu, 20 Oct 2022 13:45:06 -0300	[thread overview]
Message-ID: <20221020164508.29182-1-mauro.lima@eclypsium.com> (raw)

Right now the only driver for Intel's spi has a DANGEROUS tag for
a bug in the past on certain Lenovo platforms. It was cleared out
that the bug was caused for the spi software sequencing mechanism
and if we only use the driver with the hardware sequencing
capabilities will be much safer[1].

This changes will remove all the software sequencing bits from
the driver and left only the hardware sequencing functionality.
If the software sequencing capabilities are needed, the old driver
can be build using the DANGEROUS option from the menu.

[1] https://lkml.org/lkml/2021/11/11/468

Mauro Lima (2):
  spi: intel-spi: Move software sequencing logic outside the core
  spi: intel-spi: build the driver with hardware sequencing by default

 drivers/spi/Kconfig            |  15 +-
 drivers/spi/Makefile           |   2 +-
 drivers/spi/spi-intel-common.h | 171 +++++++++++++++++
 drivers/spi/spi-intel-swseq.c  | 231 +++++++++++++++++++++++
 drivers/spi/spi-intel-swseq.h  |  23 +++
 drivers/spi/spi-intel.c        | 326 +++------------------------------
 6 files changed, 464 insertions(+), 304 deletions(-)
 create mode 100644 drivers/spi/spi-intel-common.h
 create mode 100644 drivers/spi/spi-intel-swseq.c
 create mode 100644 drivers/spi/spi-intel-swseq.h

-- 
2.34.3


             reply	other threads:[~2022-10-20 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 16:45 Mauro Lima [this message]
2022-10-20 16:45 ` [PATCH 1/2] spi: intel-spi: Move software sequencing logic outside the core Mauro Lima
2022-10-23  5:45   ` Mika Westerberg
2022-10-20 16:45 ` [PATCH 2/2] spi: intel-spi: build the driver with hardware sequencing by default Mauro Lima
2022-10-25  6:09 ` [PATCH 0/2] intel-spi: Split hardware and software sequencing Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020164508.29182-1-mauro.lima@eclypsium.com \
    --to=mauro.lima@eclypsium.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).