From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86366C678DB for ; Mon, 16 Jan 2023 14:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232273AbjAPOOx (ORCPT ); Mon, 16 Jan 2023 09:14:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232540AbjAPONx (ORCPT ); Mon, 16 Jan 2023 09:13:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EC9325E0C; Mon, 16 Jan 2023 06:05:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE90F60FB3; Mon, 16 Jan 2023 14:05:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94ADFC433D2; Mon, 16 Jan 2023 14:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673877911; bh=w8L3t+EN+6bQUlyLjwdWyrv/1d7FvQymIq9GJhEMmis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rKu4mv5QUz5E5gSmOui+U/GBhXSOTqkasKi1lezEH5Ho4rM/tClKXL2oIfXB0DV8y 6aCJmgqgruL66NGfcepR7/wofNC506CCyq9il5p9fx0EFL7IzPBJ5f3xgO3F9LURj8 YVCMe6L7+YFOOKg8fSBnbpuQ/G0irXAaBESkbaF7TKUAuoNEXBZ4RCfgj/ay8jRV7l 1Y2z3AwUQcsYzTv1z1m1yC2pBgNtvu2jOnu3uclHqR2B+G31hrYtCpChIvutwS6rbR OeKQcmsVvbdiyess5cuBkpfXe7HrNPZMAw/RFr0g9rA0b+NvNJyiQfppYYVTVST+rR cB4bOu3QssZGQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Bartosz Golaszewski , Mark Brown , Sasha Levin , linux-spi@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 12/17] spi: spidev: remove debug messages that access spidev->spi without locking Date: Mon, 16 Jan 2023 09:04:43 -0500 Message-Id: <20230116140448.116034-12-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230116140448.116034-1-sashal@kernel.org> References: <20230116140448.116034-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: Bartosz Golaszewski [ Upstream commit 6b35b173dbc1711f8d272e3f322d2ad697015919 ] The two debug messages in spidev_open() dereference spidev->spi without taking the lock and without checking if it's not null. This can lead to a crash. Drop the messages as they're not needed - the user-space will get informed about ENOMEM with the syscall return value. Signed-off-by: Bartosz Golaszewski Link: https://lore.kernel.org/r/20230106100719.196243-2-brgl@bgdev.pl Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spidev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 87c4d641cbd5..05b0585d5ced 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -594,7 +594,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->tx_buffer) { spidev->tx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->tx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_find_dev; } @@ -603,7 +602,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->rx_buffer) { spidev->rx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->rx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_alloc_rx_buf; } -- 2.35.1