From: Mauro Lima <mauro.lima@eclypsium.com>
To: mika.westerberg@linux.intel.com
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Lima <mauro.lima@eclypsium.com>
Subject: [PATCH 1/1] spi: intel: Remove DANGEROUS tag from pci driver
Date: Mon, 6 Feb 2023 15:31:43 -0300 [thread overview]
Message-ID: <20230206183143.75274-2-mauro.lima@eclypsium.com> (raw)
In-Reply-To: <20230206183143.75274-1-mauro.lima@eclypsium.com>
Modern CPUs exposes this controller as PCI device that only uses
hardware sequencing capabilities which is safer than software
sequencing.
Leave the platform driver as *DANGEROUS* and update help text since
most of these controllers are using software sequencing.
Signed-off-by: Mauro Lima <mauro.lima@eclypsium.com>
---
drivers/spi/Kconfig | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 87fc2bd16b72..3a362c450cb6 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -447,7 +447,7 @@ config SPI_INTEL
tristate
config SPI_INTEL_PCI
- tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)"
+ tristate "Intel PCH/PCU SPI flash PCI driver"
depends on PCI
depends on X86 || COMPILE_TEST
depends on SPI_MEM
@@ -455,8 +455,9 @@ config SPI_INTEL_PCI
help
This enables PCI support for the Intel PCH/PCU SPI controller in
master mode. This controller is present in modern Intel hardware
- and is used to hold BIOS and other persistent settings. Using
- this driver it is possible to upgrade BIOS directly from Linux.
+ and is used to hold BIOS and other persistent settings. This
+ driver only supports hardware sequencing mode. Using this
+ driver it is possible to upgrade BIOS directly from Linux.
Say N here unless you know what you are doing. Overwriting the
SPI flash may render the system unbootable.
@@ -471,10 +472,10 @@ config SPI_INTEL_PLATFORM
select SPI_INTEL
help
This enables platform support for the Intel PCH/PCU SPI
- controller in master mode. This controller is present in modern
- Intel hardware and is used to hold BIOS and other persistent
- settings. Using this driver it is possible to upgrade BIOS
- directly from Linux.
+ controller in master mode that is used to hold BIOS and other
+ persistent settings. Most of these controllers are using
+ software sequencing mode. Using this driver it is possible to
+ upgrade BIOS directly from Linux.
Say N here unless you know what you are doing. Overwriting the
SPI flash may render the system unbootable.
--
2.39.1
next prev parent reply other threads:[~2023-02-06 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 18:31 [PATCH 0/1] spi: intel: Remove DANGEROUS tag from pci driver Mauro Lima
2023-02-06 18:31 ` Mauro Lima [this message]
2023-02-07 5:56 ` [PATCH 1/1] " Mika Westerberg
2023-02-07 13:52 ` Michael Walle
2023-02-07 14:03 ` Mika Westerberg
2023-02-07 14:11 ` Michael Walle
2023-02-07 14:45 ` Mika Westerberg
2023-02-07 20:44 ` Mauro Lima
2023-02-07 11:51 ` [PATCH 0/1] " Mark Brown
2023-02-07 15:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206183143.75274-2-mauro.lima@eclypsium.com \
--to=mauro.lima@eclypsium.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).