From: William Zhang <william.zhang@broadcom.com>
To: Linux SPI List <linux-spi@vger.kernel.org>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: f.fainelli@gmail.com, dregan@mail.com, joel.peshkin@broadcom.com,
dan.beygelman@broadcom.com, anand.gore@broadcom.com,
kursad.oney@broadcom.com, tomer.yacoby@broadcom.com,
jonas.gorski@gmail.com,
William Zhang <william.zhang@broadcom.com>,
kernel test robot <lkp@intel.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 06/15] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
Date: Thu, 9 Feb 2023 12:02:37 -0800 [thread overview]
Message-ID: <20230209200246.141520-7-william.zhang@broadcom.com> (raw)
In-Reply-To: <20230209200246.141520-1-william.zhang@broadcom.com>
HSSPI controller uses big endian for the opcode in the message to the
controller ping pong buffer. Use cpu_to_be16 to properly handle the
endianness for both big and little endian host.
Fixes: 142168eba9dc ("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver")
Signed-off-by: Kursad Oney <kursad.oney@broadcom.com>
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
(no changes since v3)
Changes in v3:
- Add Acked-by tag
Changes in v2:
- Fix build error for Alpha platform
Reported-by: kernel test robot <lkp@intel.com>
drivers/spi/spi-bcm63xx-hsspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
index 01d5acad4a1b..a65a0ec67641 100644
--- a/drivers/spi/spi-bcm63xx-hsspi.c
+++ b/drivers/spi/spi-bcm63xx-hsspi.c
@@ -194,7 +194,7 @@ static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)
tx += curr_step;
}
- __raw_writew(opcode | curr_step, bs->fifo);
+ __raw_writew((u16)cpu_to_be16(opcode | curr_step), bs->fifo);
/* enable interrupt */
__raw_writel(HSSPI_PINGx_CMD_DONE(0),
--
2.37.3
next prev parent reply other threads:[~2023-02-09 20:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 20:02 [PATCH v4 00/15] spi: bcm63xx-hsspi: driver and doc updates William Zhang
2023-02-09 20:02 ` [PATCH v4 01/15] dt-bindings: spi: Convert bcm63xx-hsspi bindings to json-schema William Zhang
2023-02-09 20:02 ` [PATCH v4 02/15] dt-bindings: spi: Add bcmbca-hsspi controller support William Zhang
2023-02-09 20:02 ` [PATCH v4 03/15] ARM: dts: broadcom: bcmbca: Add spi controller node William Zhang
2023-02-09 20:02 ` [PATCH v4 04/15] arm64: " William Zhang
2023-02-09 20:02 ` [PATCH v4 05/15] spi: bcm63xx-hsspi: Add new compatible string support William Zhang
2023-02-09 20:02 ` William Zhang [this message]
2023-02-09 20:02 ` [PATCH v4 07/15] spi: bcm63xx-hsspi: Add polling mode support William Zhang
2023-02-09 20:02 ` [PATCH v4 08/15] spi: export spi_transfer_cs_change_delay_exec function William Zhang
2023-02-09 20:02 ` [PATCH v4 09/15] spi: bcm63xx-hsspi: Handle cs_change correctly William Zhang
2023-02-09 20:02 ` [PATCH v4 10/15] spi: bcm63xx-hsspi: Fix multi-bit mode setting William Zhang
2023-02-09 20:02 ` [PATCH v4 11/15] spi: bcm63xx-hsspi: Add prepend mode support William Zhang
2023-02-09 20:02 ` [PATCH v4 12/15] spi: spi-mem: Allow controller supporting mem_ops without exec_op William Zhang
2023-02-09 20:02 ` [PATCH v4 13/15] spi: bcm63xx-hsspi: Disable spi mem dual io read op support William Zhang
2023-02-09 20:02 ` [PATCH v4 14/15] spi: bcmbca-hsspi: Add driver for newer HSSPI controller William Zhang
2023-02-09 20:02 ` [PATCH v4 15/15] MAINTAINERS: Add entry for Broadcom Broadband SoC HS SPI drivers William Zhang
2023-02-10 12:53 ` [PATCH v4 00/15] spi: bcm63xx-hsspi: driver and doc updates Mark Brown
2023-02-11 0:54 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209200246.141520-7-william.zhang@broadcom.com \
--to=william.zhang@broadcom.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=dan.beygelman@broadcom.com \
--cc=dregan@mail.com \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kursad.oney@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tomer.yacoby@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).