linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: linux-spi@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andi Shyti <andi@etezian.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Eddie James <eajames@linux.ibm.com>, Han Xu <han.xu@nxp.com>,
	Haibo Chen <haibo.chen@nxp.com>,
	Yogesh Gaur <yogeshgaur.83@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>, Mark Brown <broonie@kernel.org>
Subject: [PATCH 7/8] spi: s3c24xx: Only have compile time references to FIQ when building it
Date: Thu, 23 Feb 2023 17:20:27 +0000	[thread overview]
Message-ID: <20230221-spi-arch-deps-v1-7-83d1566474cf@kernel.org> (raw)
In-Reply-To: <20230221-spi-arch-deps-v1-0-83d1566474cf@kernel.org>

There is a config option which allows the FIQ code in the s3c24xx driver
to be disabled but it does not cover the inclusion of the API header or the
variables added to the driver data. Add some ifdefs protecting these so
that we can improve build coverage.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-s3c24xx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c
index ef25b5e93900..ad13c6004d40 100644
--- a/drivers/spi/spi-s3c24xx.c
+++ b/drivers/spi/spi-s3c24xx.c
@@ -21,7 +21,9 @@
 #include <linux/spi/s3c24xx-fiq.h>
 #include <linux/module.h>
 
+#ifdef CONFIG_SPI_S3C24XX_FIQ
 #include <asm/fiq.h>
+#endif
 
 #include "spi-s3c24xx-regs.h"
 
@@ -56,10 +58,12 @@ struct s3c24xx_spi {
 	int			 len;
 	int			 count;
 
+#ifdef CONFIG_SPI_S3C24XX_FIQ
 	struct fiq_handler	 fiq_handler;
 	enum spi_fiq_mode	 fiq_mode;
 	unsigned char		 fiq_inuse;
 	unsigned char		 fiq_claimed;
+#endif
 
 	/* data buffers */
 	const unsigned char	*tx;

-- 
2.30.2


  parent reply	other threads:[~2023-02-23 17:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 17:20 [PATCH 0/8] spi: Build coverage cleanups and improvements Mark Brown
2023-02-23 17:20 ` [PATCH 1/8] spi: s3c24xx: Fix dependencies when FIQ support is enabled Mark Brown
2023-02-24 11:05   ` Krzysztof Kozlowski
2023-02-23 17:20 ` [PATCH 2/8] spi: rockchip: Add architecture dependency Mark Brown
2023-02-23 17:20 ` [PATCH 3/8] spi: nxp-flexspi: Fix ARCH_LAYERSCAPE dependency Mark Brown
2023-02-23 17:20 ` [PATCH 4/8] spi: davinci: Make available for build test Mark Brown
2023-02-23 17:20 ` [PATCH 5/8] spi: fsi: " Mark Brown
2023-02-23 17:20 ` [PATCH 6/8] spi: qcom-qspi: " Mark Brown
2023-02-23 17:20 ` Mark Brown [this message]
2023-02-24 11:06   ` [PATCH 7/8] spi: s3c24xx: Only have compile time references to FIQ when building it Krzysztof Kozlowski
2023-02-23 17:20 ` [PATCH 8/8] spi: s3c24xx: Allow build test coverage Mark Brown
2023-03-06 13:32 ` [PATCH 0/8] spi: Build coverage cleanups and improvements Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221-spi-arch-deps-v1-7-83d1566474cf@kernel.org \
    --to=broonie@kernel.org \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=andi@etezian.org \
    --cc=eajames@linux.ibm.com \
    --cc=haibo.chen@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=heiko@sntech.de \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=yogeshgaur.83@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).