From: Brad Larson <blarson@amd.com>
To: <robh@kernel.org>
Cc: <adrian.hunter@intel.com>, <alcooperx@gmail.com>,
<andy.shevchenko@gmail.com>, <arnd@arndb.de>, <blarson@amd.com>,
<brendan.higgins@linux.dev>, <briannorris@chromium.org>,
<brijeshkumar.singh@amd.com>, <broonie@kernel.org>,
<catalin.marinas@arm.com>, <davidgow@google.com>,
<devicetree@vger.kernel.org>, <fancer.lancer@gmail.com>,
<gerg@linux-m68k.org>, <gsomlo@gmail.com>, <krzk@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <lee.jones@linaro.org>,
<lee@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <p.yadav@ti.com>,
<p.zabel@pengutronix.de>, <piotrs@cadence.com>,
<rdunlap@infradead.org>, <samuel@sholland.org>,
<skhan@linuxfoundation.org>, <suravee.suthikulpanit@amd.com>,
<thomas.lendacky@amd.com>, <tonyhuang.sunplus@gmail.com>,
<ulf.hansson@linaro.org>, <vaishnav.a@ti.com>, <will@kernel.org>,
<yamada.masahiro@socionext.com>
Subject: Re: [PATCH v13 08/15] arm64: dts: Add AMD Pensando Elba SoC support
Date: Wed, 12 Apr 2023 17:51:41 -0700 [thread overview]
Message-ID: <20230413005141.24632-1-blarson@amd.com> (raw)
In-Reply-To: <20230411135518.GA2952600-robh@kernel.org>
Hi Rob,
On Tue, Apr 11, 2023 at 08:55:18, Rob Herring wrote:
> On Mon, Apr 10, 2023 at 11:45:19AM -0700, Brad Larson wrote:
>> Add AMD Pensando common and Elba SoC specific device nodes
>>
>> Signed-off-by: Brad Larson <blarson@amd.com>
>> ---
>>
>> v11 changes:
>> - Delete reset-names
>> - Fix spi0 compatible to be specific 'amd,pensando-elba-ctrl'
>>
>> v9 changes:
>> - Single node for spi0 system-controller and squash
>> the reset-controller child into parent
>
> Have you run this thru 'make dtbs_check'? I see at least one issue that
> should report.
Yes and no warnings or errors with these checks
make ARCH=arm64 dtbs_check
make DT_CHECKER_FLAGS=-m dt_binding_check
but I did find a couple relevant packages have been updated
dtschema Version: 2023.1 ==> 2023.4
yamllint Version: 1.26.3 ==> 1.30.0
and then running again I get below
$ make ARCH=arm64 dtbs_check
...
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache0: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache0: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache0: 'cache-unified' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache1: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache1: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache1: 'cache-unified' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache2: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache2: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache2: 'cache-unified' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache3: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache3: 'cache-level' is a required property
/home/brad/linux.v13/arch/arm64/boot/dts/amd/elba-asic.dtb: l2-cache3: 'cache-unified' is a required property
I'll fix this in the next spin.
Regards,
Brad
next prev parent reply other threads:[~2023-04-13 0:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 18:45 [PATCH v13 00/15] Support AMD Pensando Elba SoC Brad Larson
2023-04-10 18:45 ` [PATCH v13 01/15] dt-bindings: arm: add AMD Pensando boards Brad Larson
2023-04-10 18:45 ` [PATCH v13 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Brad Larson
2023-04-17 14:54 ` Ulf Hansson
2023-04-10 18:45 ` [PATCH v13 03/15] dt-bindings: spi: cdns: Add compatible for " Brad Larson
2023-04-17 17:15 ` Mark Brown
2023-04-18 21:49 ` [PATCH v14 " Brad Larson
2023-04-10 18:45 ` [PATCH v13 04/15] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller Brad Larson
2023-04-10 18:45 ` [PATCH v13 05/15] dt-bindings: soc: amd: amd,pensando-elba-ctrl: Add Pensando SoC Controller Brad Larson
2023-04-10 18:45 ` [PATCH v13 06/15] MAINTAINERS: Add entry for AMD PENSANDO Brad Larson
2023-04-10 18:45 ` [PATCH v13 07/15] arm64: Add config for AMD Pensando SoC platforms Brad Larson
2023-04-10 18:45 ` [PATCH v13 08/15] arm64: dts: Add AMD Pensando Elba SoC support Brad Larson
2023-04-11 13:55 ` Rob Herring
2023-04-13 0:51 ` Brad Larson [this message]
2023-04-21 21:05 ` [PATCH v14 " Brad Larson
2023-04-10 18:45 ` [PATCH v13 09/15] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Brad Larson
2023-04-10 18:45 ` [PATCH v13 10/15] spi: dw: Add support " Brad Larson
2023-04-10 18:45 ` [PATCH v13 11/15] mmc: sdhci-cadence: Enable device specific override of writel() Brad Larson
2023-04-17 14:54 ` Ulf Hansson
2023-04-10 18:45 ` [PATCH v13 12/15] mmc: sdhci-cadence: Support device specific init during probe Brad Larson
2023-04-17 14:54 ` Ulf Hansson
2023-04-10 18:45 ` [PATCH v13 13/15] mmc: sdhci-cadence: Add AMD Pensando Elba SoC support Brad Larson
2023-04-17 14:54 ` Ulf Hansson
2023-04-10 18:45 ` [PATCH v13 14/15] mmc: sdhci-cadence: Support mmc hardware reset Brad Larson
2023-04-17 14:54 ` Ulf Hansson
2023-04-10 18:45 ` [PATCH v13 15/15] soc: amd: Add support for AMD Pensando SoC Controller Brad Larson
2023-04-11 9:20 ` Andy Shevchenko
2023-04-20 22:52 ` Brad Larson
2023-04-21 21:38 ` [PATCH v14 " Brad Larson
2023-04-17 19:28 ` (subset) [PATCH v13 00/15] Support AMD Pensando Elba SoC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413005141.24632-1-blarson@amd.com \
--to=blarson@amd.com \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=brendan.higgins@linux.dev \
--cc=briannorris@chromium.org \
--cc=brijeshkumar.singh@amd.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gerg@linux-m68k.org \
--cc=gsomlo@gmail.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.yadav@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=piotrs@cadence.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=skhan@linuxfoundation.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=tonyhuang.sunplus@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vaishnav.a@ti.com \
--cc=will@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).