linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joy Chakraborty <joychakr@google.com>
To: Serge Semin <fancer.lancer@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	manugautam@google.com, rohitner@google.com,
	Joy Chakraborty <joychakr@google.com>
Subject: [PATCH v7 4/5] spi: dw: Add DMA address widths capability check
Date: Tue, 18 Apr 2023 05:29:01 +0000	[thread overview]
Message-ID: <20230418052902.1336866-5-joychakr@google.com> (raw)
In-Reply-To: <20230418052902.1336866-1-joychakr@google.com>

Store address width capabilities of DMA controller during init and check
the same per transfer to make sure the bits/word requirement can be met.

Current DW DMA driver requires both tx and rx channel to be configured
and functional hence a subset of both tx and rx channel address width
capability is checked with the width requirement(n_bytes) for a
transfer.

Signed-off-by: Joy Chakraborty <joychakr@google.com>
---
 drivers/spi/spi-dw-dma.c | 16 +++++++++++++++-
 drivers/spi/spi-dw.h     |  1 +
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-dw-dma.c b/drivers/spi/spi-dw-dma.c
index 22d0727a3789..45980c46946d 100644
--- a/drivers/spi/spi-dw-dma.c
+++ b/drivers/spi/spi-dw-dma.c
@@ -97,6 +97,14 @@ static int dw_spi_dma_caps_init(struct dw_spi *dws)
 		dws->dma_sg_burst = rx.max_sg_burst;
 	else
 		dws->dma_sg_burst = 0;
+
+	/*
+	 * Assuming both channels belong to the same DMA controller hence the
+	 * address width capabilities most likely would be the same.
+	 */
+	dws->dma_addr_widths = tx.dst_addr_widths & rx.src_addr_widths;
+
+	return 0;
 }
 
 static int dw_spi_dma_init_mfld(struct device *dev, struct dw_spi *dws)
@@ -237,8 +245,14 @@ static bool dw_spi_can_dma(struct spi_controller *master,
 			   struct spi_device *spi, struct spi_transfer *xfer)
 {
 	struct dw_spi *dws = spi_controller_get_devdata(master);
+	enum dma_slave_buswidth dma_bus_width;
+
+	if (xfer->len <= dws->fifo_len)
+		return false;
+
+	dma_bus_width = dw_spi_dma_convert_width(dws->n_bytes);
 
-	return xfer->len > dws->fifo_len;
+	return dws->dma_addr_widths & BIT(dma_bus_width);
 }
 
 static int dw_spi_dma_wait(struct dw_spi *dws, unsigned int len, u32 speed)
diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
index 9e8eb2b52d5c..3962e6dcf880 100644
--- a/drivers/spi/spi-dw.h
+++ b/drivers/spi/spi-dw.h
@@ -190,6 +190,7 @@ struct dw_spi {
 	struct dma_chan		*rxchan;
 	u32			rxburst;
 	u32			dma_sg_burst;
+	u32			dma_addr_widths;
 	unsigned long		dma_chan_busy;
 	dma_addr_t		dma_addr; /* phy address of the Data register */
 	const struct dw_spi_dma_ops *dma_ops;
-- 
2.40.0.634.g4ca3ef3211-goog


  parent reply	other threads:[~2023-04-18  5:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18  5:28 [PATCH v7 0/5] spi: dw: DW SPI DMA Driver updates Joy Chakraborty
2023-04-18  5:28 ` [PATCH v7 1/5] spi: dw: Add 32 bpw support to SPI DW DMA driver Joy Chakraborty
2023-04-18  5:28 ` [PATCH v7 2/5] spi: dw: Move dw_spi_can_dma() Joy Chakraborty
2023-04-18  5:29 ` [PATCH v7 3/5] spi: dw: Add DMA directional capability check Joy Chakraborty
2023-04-18  5:29 ` Joy Chakraborty [this message]
2023-04-18  7:38   ` [PATCH v7 4/5] spi: dw: Add DMA address widths " Andy Shevchenko
2023-04-19  5:48     ` Joy Chakraborty
2023-04-19 11:49       ` Andy Shevchenko
2023-04-19 12:48         ` Joy Chakraborty
2023-04-19 14:55           ` Joy Chakraborty
2023-04-19 17:35           ` Andy Shevchenko
2023-04-19 21:03             ` Joy Chakraborty
2023-04-18  5:29 ` [PATCH v7 5/5] spi: dw: Round of n_bytes to power of 2 Joy Chakraborty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230418052902.1336866-5-joychakr@google.com \
    --to=joychakr@google.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manugautam@google.com \
    --cc=rohitner@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).