[PATCH 1/3] spi: dt-bindings: allwinner: simplify with unevaluatedProperties

[PATCH 1/3] spi: dt-bindings: allwinner: simplify with unevaluatedProperties

[Krzysztof Kozlowski]

Remove properties already mentioned by common spi-controller.yaml and
switch to unevaluatedProperties:false to achieve same functional effect.
This makes the binding a bit smaller.  Similarly there is no need to
allow additionalProperties for children, because spi-controller.yaml
already does it.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml  | 8 +-------
 .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml  | 8 +-------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
index 2155478bfc4d..a6f34bdd1d3c 100644
--- a/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml
@@ -14,9 +14,6 @@ maintainers:
   - Maxime Ripard <mripard@kernel.org>
 
 properties:
-  "#address-cells": true
-  "#size-cells": true
-
   compatible:
     const: allwinner,sun4i-a10-spi
 
@@ -46,12 +43,9 @@ properties:
       - const: rx
       - const: tx
 
-  num-cs: true
-
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
-    additionalProperties: true
     properties:
       reg:
         items:
@@ -71,7 +65,7 @@ required:
   - clocks
   - clock-names
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
index fa5260eca531..28b8ace63044 100644
--- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
@@ -14,9 +14,6 @@ maintainers:
   - Maxime Ripard <mripard@kernel.org>
 
 properties:
-  "#address-cells": true
-  "#size-cells": true
-
   compatible:
     oneOf:
       - const: allwinner,sun50i-r329-spi
@@ -68,12 +65,9 @@ properties:
       - const: rx
       - const: tx
 
-  num-cs: true
-
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
-    additionalProperties: true
     properties:
       reg:
         items:
@@ -93,7 +87,7 @@ required:
   - clocks
   - clock-names
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1

[PATCH 2/3] spi: dt-bindings: samsung: drop cs-gpios

[Krzysztof Kozlowski]

Remove cs-gpios because it is already mentioned by common
spi-controller.yaml.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/spi/samsung,spi.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml
index e0a465d70b0a..79da99ca0e53 100644
--- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml
+++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml
@@ -35,8 +35,6 @@ properties:
     minItems: 2
     maxItems: 3
 
-  cs-gpios: true
-
   dmas:
     minItems: 2
     maxItems: 2
-- 
2.34.1

Re: [PATCH 2/3] spi: dt-bindings: samsung: drop cs-gpios

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

On Thu, Jun 01, 2023 at 11:59:07AM +0200, Krzysztof Kozlowski wrote:
> Remove cs-gpios because it is already mentioned by common
> spi-controller.yaml.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 3/3] spi: dt-bindings: socionext,uniphier: drop address/size-cells

[Krzysztof Kozlowski]

Remove address/size-cells because they are already mentioned by common
spi-controller.yaml.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/spi/socionext,uniphier-spi.yaml        | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml b/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml
index 597fc4e6b01c..c96131ebbea1 100644
--- a/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml
@@ -17,9 +17,6 @@ allOf:
   - $ref: spi-controller.yaml#
 
 properties:
-  "#address-cells": true
-  "#size-cells": true
-
   compatible:
     const: socionext,uniphier-scssi
 
-- 
2.34.1

Re: [PATCH 3/3] spi: dt-bindings: socionext,uniphier: drop address/size-cells

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

On Thu, Jun 01, 2023 at 11:59:08AM +0200, Krzysztof Kozlowski wrote:
> Remove address/size-cells because they are already mentioned by common
> spi-controller.yaml.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/3] spi: dt-bindings: allwinner: simplify with unevaluatedProperties

[Jernej Škrabec]

Dne četrtek, 01. junij 2023 ob 11:59:06 CEST je Krzysztof Kozlowski napisal(a):
> Remove properties already mentioned by common spi-controller.yaml and
> switch to unevaluatedProperties:false to achieve same functional effect.
> This makes the binding a bit smaller.  Similarly there is no need to
> allow additionalProperties for children, because spi-controller.yaml
> already does it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

Re: [PATCH 1/3] spi: dt-bindings: allwinner: simplify with unevaluatedProperties

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

On Thu, Jun 01, 2023 at 11:59:06AM +0200, Krzysztof Kozlowski wrote:
> Remove properties already mentioned by common spi-controller.yaml and
> switch to unevaluatedProperties:false to achieve same functional effect.
> This makes the binding a bit smaller.  Similarly there is no need to
> allow additionalProperties for children, because spi-controller.yaml
> already does it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/3] spi: dt-bindings: allwinner: simplify with unevaluatedProperties

[Mark Brown]

On Thu, 01 Jun 2023 11:59:06 +0200, Krzysztof Kozlowski wrote:
> Remove properties already mentioned by common spi-controller.yaml and
> switch to unevaluatedProperties:false to achieve same functional effect.
> This makes the binding a bit smaller.  Similarly there is no need to
> allow additionalProperties for children, because spi-controller.yaml
> already does it.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] spi: dt-bindings: allwinner: simplify with unevaluatedProperties
      commit: c092a878729843c10160c6f22864507ab7dbceb2
[2/3] spi: dt-bindings: samsung: drop cs-gpios
      commit: bbd25f1ae8bfaeb99de2a0e1985d206cd39ac014
[3/3] spi: dt-bindings: socionext,uniphier: drop address/size-cells
      commit: 34fcc0f0a410ff67aba99875d0452a0762d5a98d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark