From: Rob Herring <robh@kernel.org>
To: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
Cc: Oleksii_Moisieiev@epam.com, gregkh@linuxfoundation.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
alexandre.torgue@foss.st.com, vkoul@kernel.org, jic23@kernel.org,
olivier.moysan@foss.st.com, arnaud.pouliquen@foss.st.com,
mchehab@kernel.org, fabrice.gasnier@foss.st.com,
andi.shyti@kernel.org, ulf.hansson@linaro.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
hugues.fruchet@foss.st.com, lee@kernel.org, will@kernel.org,
catalin.marinas@arm.com, arnd@kernel.org,
richardcochran@gmail.com, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org,
alsa-devel@alsa-project.org, linux-media@vger.kernel.org,
linux-mmc@vger.kernel.org, netdev@vger.kernel.org,
linux-phy@lists.infradead.org, linux-serial@vger.kernel.org,
linux-spi@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 04/10] dt-bindings: treewide: add feature-domains description in binding files
Date: Fri, 7 Jul 2023 09:20:56 -0600 [thread overview]
Message-ID: <20230707152056.GA317056-robh@kernel.org> (raw)
In-Reply-To: <0aaace47-1bb4-82c5-57a5-6f5d27eb4d45@foss.st.com>
On Fri, Jul 07, 2023 at 02:28:28PM +0200, Gatien CHEVALLIER wrote:
> Hello Rob,
>
> On 7/6/23 16:51, Rob Herring wrote:
> > On Wed, Jul 05, 2023 at 07:27:53PM +0200, Gatien Chevallier wrote:
> > > feature-domains is an optional property that allows a peripheral to
> > > refer to one or more feature domain controller(s).
> > >
> > > Description of this property is added to all peripheral binding files of
> > > the peripheral under the STM32 firewall controllers. It allows an accurate
> > > representation of the hardware, where various peripherals are connected
> > > to this firewall bus. The firewall can then check the peripheral accesses
> > > before allowing it to probe.
> > >
> > > Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
> > > ---
> > >
> > > Disclaimer: Some error with dtbs_check will be observed as I've
> > > considered the property to be generic, as Rob asked
> > >
> > > Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 4 ++++
> > > Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 4 ++++
> > > Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 4 ++++
> > > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 4 ++++
> > > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 4 ++++
> > > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 4 ++++
> > > Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 4 ++++
> > > .../devicetree/bindings/media/cec/st,stm32-cec.yaml | 4 ++++
> > > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 ++++
> > > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 4 ++++
> > > Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 4 ++++
> > > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 5 +++++
> > > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 ++++
> > > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 4 ++++
> > > Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 4 ++++
> > > .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 4 ++++
> > > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 4 ++++
> > > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 4 ++++
> > > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 4 ++++
> > > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 4 ++++
> > > .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 4 ++++
> > > Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 4 ++++
> > > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 4 ++++
> > > Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
> > > 24 files changed, 97 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> > > index b767ec72a999..daf8dcaef627 100644
> > > --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> > > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> > > @@ -50,6 +50,10 @@ properties:
> > > power-domains:
> > > maxItems: 1
> > > + feature-domains:
> > > + minItems: 1
> > > + maxItems: 3
> >
> > What are the 3 entries?
> >
> > Rob
>
> I thought I was benefiting from the description of the pattern-property in
> the RIFSC YAML file. But yes anyway, it seems like it needs some description
> here as the dependency does not appear in this file.
Humm, that should limit the maximum entries to 2, so 3 would never work
(if RIFSC is the parent).
> I picked 3 as a maxItems for our ST needs, I'll give it some more thought
> when coming back with something clearer.
I'd expect you have 1 entry for register bus and 1 entry for DMA bus if
there is one. It's block specific for how many entries, so the RIFSC
schema should not be setting that. You could possibly say that
'feature-domains' is required for all the child nodes though.
Rob
next prev parent reply other threads:[~2023-07-07 15:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 17:27 [PATCH 00/10] Introduce STM32 Firewall framework Gatien Chevallier
2023-07-05 17:27 ` [IGNORE][PATCH 01/10] dt-bindings: Document common device controller bindings Gatien Chevallier
2023-07-05 19:39 ` Rob Herring
2023-07-05 17:27 ` [PATCH 02/10] dt-bindings: bus: add device tree bindings for RIFSC Gatien Chevallier
2023-07-05 19:39 ` Rob Herring
2023-07-06 6:28 ` Krzysztof Kozlowski
2023-07-06 9:29 ` Gatien CHEVALLIER
2023-07-20 14:58 ` Gatien CHEVALLIER
2023-07-05 17:27 ` [PATCH 03/10] dt-bindings: bus: add device tree bindings for ETZPC Gatien Chevallier
2023-07-05 19:39 ` Rob Herring
2023-07-05 17:27 ` [PATCH 04/10] dt-bindings: treewide: add feature-domains description in binding files Gatien Chevallier
2023-07-06 14:51 ` Rob Herring
2023-07-07 12:28 ` Gatien CHEVALLIER
2023-07-07 15:20 ` Rob Herring [this message]
2023-07-10 8:22 ` Gatien CHEVALLIER
2023-07-10 14:42 ` Rob Herring
2023-07-07 14:07 ` Oleksii Moisieiev
2023-07-07 15:26 ` Gatien CHEVALLIER
2023-07-07 15:27 ` Rob Herring
2023-07-07 16:10 ` Oleksii Moisieiev
2023-07-07 20:33 ` Rob Herring
2023-07-10 6:27 ` Oleksii Moisieiev
2023-07-05 17:27 ` [PATCH 05/10] firewall: introduce stm32_firewall framework Gatien Chevallier
2023-07-06 15:09 ` Rob Herring
2023-07-07 13:43 ` Gatien CHEVALLIER
2023-07-07 15:07 ` Rob Herring
2023-07-13 13:58 ` Gatien CHEVALLIER
2023-07-13 14:13 ` Oleksii Moisieiev
2023-07-07 10:37 ` Greg KH
2023-07-07 14:00 ` Gatien CHEVALLIER
2023-07-07 15:10 ` Greg KH
2023-07-07 15:44 ` Gatien CHEVALLIER
2023-07-07 13:50 ` Oleksii Moisieiev
2023-07-07 15:01 ` Gatien CHEVALLIER
2023-07-07 16:01 ` Oleksii Moisieiev
2023-07-05 17:27 ` [PATCH 06/10] bus: rifsc: introduce RIFSC firewall controller driver Gatien Chevallier
2023-07-05 17:27 ` [PATCH 07/10] arm64: dts: st: add RIFSC as a domain controller for STM32MP25x boards Gatien Chevallier
2023-07-06 9:25 ` Alexandre TORGUE
2023-07-06 9:30 ` Gatien CHEVALLIER
2023-07-25 14:07 ` Gatien CHEVALLIER
2023-07-05 17:27 ` [PATCH 08/10] bus: etzpc: introduce ETZPC firewall controller driver Gatien Chevallier
2023-07-05 17:27 ` [PATCH 09/10] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards Gatien Chevallier
2023-07-05 17:27 ` [PATCH 10/10] ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards Gatien Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707152056.GA317056-robh@kernel.org \
--to=robh@kernel.org \
--cc=Oleksii_Moisieiev@epam.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=andi.shyti@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=arnd@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=gatien.chevallier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hugues.fruchet@foss.st.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier.moysan@foss.st.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).