From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mark Brown" <broonie@kernel.org>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Amit Kumar Mahapatra via Alsa-devel"
<alsa-devel@alsa-project.org>,
"Kris Bahnsen" <kris@embeddedTS.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Tharun Kumar P" <tharunkumar.pasumarthi@microchip.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org
Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Alain Volmat <alain.volmat@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: [PATCH v1 8/8] spi: Use struct_size() helper
Date: Mon, 10 Jul 2023 13:27:51 +0300 [thread overview]
Message-ID: <20230710102751.83314-9-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com>
Prefer struct_size() over open-coded versions.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/spi/spi.h | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index e9fb96016dc1..d4d686af76bd 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -17,6 +17,7 @@
#include <linux/minmax.h>
#include <linux/mod_devicetable.h>
#include <linux/mutex.h>
+#include <linux/overflow.h>
#include <linux/scatterlist.h>
#include <linux/slab.h>
#include <linux/smp.h>
@@ -1100,6 +1101,8 @@ struct spi_transfer {
* @state: for use by whichever driver currently owns the message
* @resources: for resource management when the SPI message is processed
* @prepared: spi_prepare_message was called for the this message
+ * @t: for use with spi_message_alloc() when memory has message and transfers
+ * together
*
* A @spi_message is used to execute an atomic sequence of data transfers,
* each represented by a struct spi_transfer. The sequence is "atomic"
@@ -1154,6 +1157,9 @@ struct spi_message {
/* List of spi_res resources when the SPI message is processed */
struct list_head resources;
+
+ /* For embedding transfers into the memory of the message */
+ struct spi_transfer t[];
};
static inline void spi_message_init_no_memset(struct spi_message *m)
@@ -1214,16 +1220,13 @@ static inline struct spi_message *spi_message_alloc(unsigned ntrans, gfp_t flags
{
struct spi_message *m;
- m = kzalloc(sizeof(struct spi_message)
- + ntrans * sizeof(struct spi_transfer),
- flags);
+ m = kzalloc(struct_size(m, t, ntrans), flags);
if (m) {
unsigned i;
- struct spi_transfer *t = (struct spi_transfer *)(m + 1);
spi_message_init_no_memset(m);
- for (i = 0; i < ntrans; i++, t++)
- spi_message_add_tail(t, m);
+ for (i = 0; i < ntrans; i++)
+ spi_message_add_tail(&m->t[i], m);
}
return m;
}
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-07-10 10:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:27 [PATCH v1 0/8] spi: Header and core clean up and refactoring Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 1/8] spi: Remove unneeded OF node NULL checks Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 2/8] spi: Drop duplicate IDR allocation code in spi_register_controller() Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 3/8] spi: Use sysfs_emit() to instead of s*printf() Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Andy Shevchenko
2023-07-10 11:04 ` Mark Brown
2023-07-10 11:08 ` Andy Shevchenko
2023-07-10 11:10 ` Mark Brown
2023-07-10 11:19 ` Andy Shevchenko
2023-07-10 11:10 ` Andy Shevchenko
2023-07-10 11:22 ` Mark Brown
2023-07-10 12:37 ` Andy Shevchenko
2023-07-10 13:21 ` Mark Brown
2023-07-10 13:32 ` Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 5/8] spi: Sort headers alphabetically Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 6/8] spi: Clean up headers Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 7/8] spi: Fix spelling typos and acronyms capitalization Andy Shevchenko
2023-07-10 10:27 ` Andy Shevchenko [this message]
2023-07-10 13:36 ` [PATCH v1 0/8] spi: Header and core clean up and refactoring Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710102751.83314-9-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=jbrunet@baylibre.com \
--cc=jcmvbkbc@gmail.com \
--cc=khilman@baylibre.com \
--cc=kris@embeddedTS.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richardcochran@gmail.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=tudor.ambarus@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).