From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: <broonie@kernel.org>, <chin-ting_kuo@aspeedtech.com>,
<clg@kaod.org>, <joel@jms.id.au>, <andrew@aj.id.au>,
<florian.fainelli@broadcom.com>, <rjui@broadcom.com>,
<sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>,
<fancer.lancer@gmail.com>, <olteanv@gmail.com>,
<neil.armstrong@linaro.org>, <khilman@baylibre.com>,
<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>,
<conor.dooley@microchip.com>, <daire.mcnamara@microchip.com>,
<matthias.bgg@gmail.com>,
<angelogioacchino.delregno@collabora.com>,
<avifishman70@gmail.com>, <tmaimon77@gmail.com>,
<tali.perry1@gmail.com>, <venture@google.com>, <yuenn@google.com>,
<benjaminfair@google.com>, <linus.walleij@linaro.org>,
<heiko@sntech.de>, <linux-spi@vger.kernel.org>,
<linux-aspeed@lists.ozlabs.org>, <openbmc@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-riscv@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared()
Date: Tue, 22 Aug 2023 16:55:24 +0100 [thread overview]
Message-ID: <20230822165524.000062a8@Huawei.com> (raw)
In-Reply-To: <20230822131237.1022815-3-lizetao1@huawei.com>
> @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev)
>
> static void a3700_spi_remove(struct platform_device *pdev)
> {
> - struct spi_controller *host = platform_get_drvdata(pdev);
> - struct a3700_spi *spi = spi_controller_get_devdata(host);
> -
> - clk_unprepare(spi->clk);
Hi.
No point in keeping an empty remove function. Drop the whole thing now
there is nothing to do.
Jonathan
> }
>
> static struct platform_driver a3700_spi_driver = {
next prev parent reply other threads:[~2023-08-22 15:55 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:12 [PATCH -next 00/25] spi: Use devm_clk_get_*() helper function to simplify the drivers Li Zetao
2023-08-22 13:12 ` [PATCH -next 01/25] spi: ar934x: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-22 13:12 ` [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Li Zetao
2023-08-22 15:55 ` Jonathan Cameron [this message]
2023-08-22 13:12 ` [PATCH -next 03/25] spi: aspeed: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-23 7:11 ` Chin-Ting Kuo
2023-08-24 8:55 ` Cédric Le Goater
2023-08-22 13:12 ` [PATCH -next 04/25] spi: ath79: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 05/25] spi: spi-axi-spi-engine: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 06/25] spi: bcm2835: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 07/25] spi: bcm2835aux: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 08/25] spi: spi-cadence: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 09/25] spi: spi-cavium-thunderx: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 10/25] spi: davinci: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 11/25] spi: dw-bt1: " Li Zetao
2023-08-22 13:48 ` Serge Semin
2023-08-22 13:12 ` [PATCH -next 12/25] spi: dw-mmio: Use helper function devm_clk_get_*() Li Zetao
2023-08-22 13:46 ` Serge Semin
2023-08-22 13:12 ` [PATCH -next 13/25] spi: spi-fsl-dspi: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-22 13:12 ` [PATCH -next 14/25] spi: lantiq-ssc: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 15/25] spi: meson-spicc: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 16/25] spi: spi-meson-spifc: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 17/25] spi: microchip-core-qspi: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 18/25] spi: microchip-core: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 19/25] spi: mtk-snfi: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 20/25] spi: npcm-fiu: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 21/25] spi: orion: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 22/25] spi: pic32-sqi: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 23/25] spi: pic32: " Li Zetao
2023-08-22 13:12 ` [PATCH -next 24/25] spi: spl022: " Li Zetao
2023-08-22 16:14 ` Jonathan Cameron
2023-08-23 6:55 ` Linus Walleij
2023-08-22 13:12 ` [PATCH -next 25/25] spi: rockchip: " Li Zetao
2023-10-04 21:18 ` Heiko Stübner
2023-08-22 16:16 ` [PATCH -next 00/25] spi: Use devm_clk_get_*() helper function to simplify the drivers Jonathan Cameron
2023-08-23 13:39 ` [PATCH -next v2 " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 01/25] spi: ar934x: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared() Li Zetao
2023-08-23 17:10 ` Jonathan Cameron
2023-08-23 13:39 ` [PATCH -next v2 03/25] spi: aspeed: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 04/25] spi: ath79: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 05/25] spi: spi-axi-spi-engine: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 06/25] spi: bcm2835: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 07/25] spi: bcm2835aux: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 08/25] spi: spi-cadence: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 09/25] spi: spi-cavium-thunderx: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 10/25] spi: davinci: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 11/25] spi: dw-bt1: " Li Zetao
2023-08-23 14:35 ` Serge Semin
2023-08-23 17:13 ` Jonathan Cameron
2023-08-25 18:01 ` Serge Semin
2023-08-23 13:39 ` [PATCH -next v2 12/25] spi: dw-mmio: Use helper function devm_clk_get_*() Li Zetao
2023-08-23 14:20 ` Serge Semin
2023-08-23 17:15 ` Jonathan Cameron
2023-08-23 13:39 ` [PATCH -next v2 13/25] spi: spi-fsl-dspi: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 14/25] spi: lantiq-ssc: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 15/25] spi: meson-spicc: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 16/25] spi: spi-meson-spifc: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 17/25] spi: microchip-core-qspi: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 18/25] spi: microchip-core: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 19/25] spi: mtk-snfi: " Li Zetao
2023-09-13 9:15 ` AngeloGioacchino Del Regno
2023-08-23 13:39 ` [PATCH -next v2 20/25] spi: npcm-fiu: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 21/25] spi: orion: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 22/25] spi: pic32-sqi: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 23/25] spi: pic32: " Li Zetao
2023-08-23 13:39 ` [PATCH -next v2 24/25] spi: spl022: " Li Zetao
2023-08-23 17:16 ` Jonathan Cameron
2023-08-23 13:39 ` [PATCH -next v2 25/25] spi: rockchip: " Li Zetao
2023-08-23 14:33 ` [PATCH -next v2 00/25] spi: Use devm_clk_get_*() helper function to simplify the drivers Mark Brown
2023-09-12 11:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822165524.000062a8@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andrew@aj.id.au \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=clg@kaod.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=fancer.lancer@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=joel@jms.id.au \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).