From: David Lechner <dlechner@baylibre.com>
To: linux-spi@vger.kernel.org
Cc: "David Lechner" <dlechner@baylibre.com>,
"Mark Brown" <broonie@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 5/9] spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep()
Date: Mon, 4 Dec 2023 11:33:31 -0600 [thread overview]
Message-ID: <20231204-axi-spi-engine-series-2-v1-5-063672323fce@baylibre.com> (raw)
In-Reply-To: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com>
This replaces the xfer parameter of spi_engine_gen_sleep() in the AXI
SPI Engine driver with parameters for the delay in nanoseconds and the
SPI SCLK rate. This will allow this function to be used by callers in
the future that do not have a spi_transfer struct.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/spi/spi-axi-spi-engine.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index b3e72308fcc5..84ec37732d8b 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -168,17 +168,16 @@ static void spi_engine_gen_xfer(struct spi_engine_program *p, bool dry,
}
static void spi_engine_gen_sleep(struct spi_engine_program *p, bool dry,
- struct spi_transfer *xfer)
+ int delay_ns, u32 sclk_hz)
{
unsigned int t;
- int delay_ns;
- delay_ns = spi_delay_to_ns(&xfer->delay, xfer);
+ /* negative delay indicates error, e.g. from spi_delay_to_ns() */
if (delay_ns <= 0)
return;
/* rounding down since executing the instruction adds a couple of ticks delay */
- t = DIV_ROUND_DOWN_ULL((u64)delay_ns * xfer->effective_speed_hz, NSEC_PER_SEC);
+ t = DIV_ROUND_DOWN_ULL((u64)delay_ns * sclk_hz, NSEC_PER_SEC);
while (t) {
unsigned int n = min(t, 256U);
@@ -256,7 +255,8 @@ static void spi_engine_compile_message(struct spi_message *msg, bool dry,
}
spi_engine_gen_xfer(p, dry, xfer);
- spi_engine_gen_sleep(p, dry, xfer);
+ spi_engine_gen_sleep(p, dry, spi_delay_to_ns(&xfer->delay, xfer),
+ xfer->effective_speed_hz);
if (xfer->cs_change) {
if (list_is_last(&xfer->transfer_list, &msg->transfers)) {
--
2.43.0
next prev parent reply other threads:[~2023-12-04 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:33 [PATCH 0/9] spi: axi-spi-engine: improvements round 2 David Lechner
2023-12-04 17:33 ` [PATCH 1/9] spi: axi-spi-engine: return void from spi_engine_compile_message() David Lechner
2023-12-04 17:33 ` [PATCH 2/9] spi: axi-spi-engine: populate xfer->effective_speed_hz David Lechner
2023-12-04 17:33 ` [PATCH 3/9] spi: axi-spi-engine: remove spi_engine_get_clk_div() David Lechner
2023-12-04 17:33 ` [PATCH 4/9] spi: axi-spi-engine: fix sleep ticks calculation David Lechner
2023-12-04 17:33 ` David Lechner [this message]
2023-12-04 17:33 ` [PATCH 6/9] spi: axi-spi-engine: implement xfer->cs_change_delay David Lechner
2023-12-04 17:33 ` [PATCH 7/9] spi: axi-spi-engine: restore clkdiv at end of message David Lechner
2023-12-04 17:33 ` [PATCH 8/9] spi: axi-spi-engine: remove delay from CS assertion David Lechner
2023-12-04 17:33 ` [PATCH 9/9] spi: axi-spi-engine: add watchdog timer David Lechner
2023-12-05 15:12 ` [PATCH 0/9] spi: axi-spi-engine: improvements round 2 Nuno Sá
2023-12-05 15:52 ` Hennerich, Michael
2023-12-06 21:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204-axi-spi-engine-series-2-v1-5-063672323fce@baylibre.com \
--to=dlechner@baylibre.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).