From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels peripheral property
Date: Wed, 10 Jan 2024 09:09:40 +0000 [thread overview]
Message-ID: <20240110090940.00002f31@Huawei.com> (raw)
In-Reply-To: <CAMknhBGNDV7+C4wE8ced5jhe-0eydo7g8SZMJwLnFi+y_qon_w@mail.gmail.com>
On Mon, 8 Jan 2024 11:15:31 -0600
David Lechner <dlechner@baylibre.com> wrote:
> On Mon, Jan 8, 2024 at 10:39 AM Mark Brown <broonie@kernel.org> wrote:
> >
> > On Sun, Jan 07, 2024 at 05:02:56PM -0600, David Lechner wrote:
> > > On Sun, Jan 7, 2024 at 3:27 PM Mark Brown <broonie@kernel.org> wrote:
> >
> > > > This makes no sense to me without a corresponding change in the SPI core
> > > > and possibly controller support, though I guess you could do data
> > > > manging to rewrite from a normal parallel SPI to this for a pure
> > > > software implementation. I also see nothing in the driver that even
> > > > attempts to parse this so I can't see how it could possibly work.
> >
> > > We currently don't have a controller that supports this. This is just
> > > an attempt to make a complete binding for a peripheral according to
> > > [2] which says:
> >
> > ...
> >
> > > So, will DT maintainers accept an incomplete binding for the
> > > peripheral? Or will you reconsider this without SPI core support if I
> > > can explain it better? It doesn't seem like a reasonable request to
> > > expect us to spend time developing software that we don't need at this
> > > time just to get a complete DT binding accepted for a feature that
> > > isn't being used.
> >
> > I don't think it's sensible to try to make a binding for this without
> > having actually tried to put a system together that uses it and made
> > sure that everything is joined up properly, the thing about complete
> > bindings is more for things that are handle turning than for things that
> > are substantial new features in subsystems.
>
> We do have plans to eventually implement such a feature in an
> FPGA-based SPI controller, so if we need to wait until then for the
> binding, then we can do that. But it would be really nice if we could
> find a way forward for the IIO driver in this series without having to
> wait for the resolution of new SPI controller feature for the complete
> DT bindings.
>
> DT/IIO maintainers, if I resubmit this series with the
> `spi-rx-bus-channels` parts removed from the iio/adc/adi,ad7380.yaml
> bindings, would that be acceptable? (Also resubmitting without this
> patch of course.)
>
From IIO side of things that's fine with me.
Jonathan
next prev parent reply other threads:[~2024-01-10 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 10:32 [PATCH v3 0/3] iio: adc: add new ad7380 driver David Lechner
2023-12-15 10:32 ` [PATCH v3 1/3] dt-bindings: spi: add spi-rx-bus-channels peripheral property David Lechner
2023-12-15 19:58 ` Rob Herring
2024-01-07 16:43 ` Jonathan Cameron
2024-01-07 21:26 ` Mark Brown
2024-01-07 23:02 ` David Lechner
2024-01-08 8:40 ` Krzysztof Kozlowski
2024-01-08 16:39 ` Mark Brown
2024-01-08 17:15 ` David Lechner
2024-01-10 9:09 ` Jonathan Cameron [this message]
2023-12-15 10:32 ` [PATCH v3 2/3] dt-bindings: iio: adc: Add binding for AD7380 ADCs David Lechner
2023-12-15 10:32 ` [PATCH v3 3/3] iio: adc: ad7380: new driver " David Lechner
2023-12-15 16:53 ` Christophe JAILLET
2023-12-15 17:31 ` David Lechner
2023-12-15 17:34 ` David Lechner
2023-12-17 14:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110090940.00002f31@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).