From: Lee Jones <lee@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, andy.shevchenko@gmail.com,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes
Date: Thu, 25 Jan 2024 13:55:09 +0000 [thread overview]
Message-ID: <20240125135509.GL74950@google.com> (raw)
In-Reply-To: <20240125102555.2621736-2-ckeepax@opensource.cirrus.com>
On Thu, 25 Jan 2024, Charles Keepax wrote:
> Use more forward declarations, move header guards to cover other
> includes, and rely less on including headers through other headers.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Patches look okay to me, but seeing as Andy suggested the changes, it
would be good to get a R-by from him.
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
> Changes since v2:
> - Added pm.h and regmap.h back into mfd/cs42l43.h
>
> Thanks,
> Charles
>
> drivers/mfd/cs42l43-i2c.c | 6 +++++-
> drivers/mfd/cs42l43-sdw.c | 6 +++++-
> drivers/mfd/cs42l43.c | 8 +++++++-
> drivers/mfd/cs42l43.h | 10 ++++++----
> include/linux/mfd/cs42l43.h | 13 +++++++------
> 5 files changed, 30 insertions(+), 13 deletions(-)
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-25 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 10:25 [PATCH v3 1/6] spi: cs42l43: Tidy up header includes Charles Keepax
2024-01-25 10:25 ` [PATCH v3 2/6] mfd: " Charles Keepax
2024-01-25 13:55 ` Lee Jones [this message]
2024-01-25 18:54 ` Andy Shevchenko
2024-01-26 9:06 ` Lee Jones
2024-01-25 18:52 ` Andy Shevchenko
2024-01-25 10:25 ` [PATCH v3 3/6] mfd: cs42l43: Use __u8 type rather than u8 for firmware interface Charles Keepax
2024-01-25 10:25 ` [PATCH v3 4/6] mfd: cs42l43: Add time postfixes on defines Charles Keepax
2024-01-25 18:49 ` Andy Shevchenko
2024-01-25 10:25 ` [PATCH v3 5/6] mfd: cs42l43: Add some missing dev_err_probe()s Charles Keepax
2024-01-25 10:25 ` [PATCH v3 6/6] mfd: cs42l43: Handle error from devm_pm_runtime_enable() Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125135509.GL74950@google.com \
--to=lee@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).