* [PATCH] spi: spi.h: add missing kernel-doc for @last_cs_index_mask
@ 2024-03-28 4:38 Randy Dunlap
2024-03-28 8:51 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2024-03-28 4:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Mark Brown, Andy Shevchenko, linux-spi
kernel-doc complains about last_cs_index_mask not described, so add its
decscription.
spi.h:778: warning: Function parameter or struct member 'last_cs_index_mask' not described in 'spi_controller'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Shevchenko <andy@kernel.org>
Cc: linux-spi@vger.kernel.org
include/linux/spi/spi.h | 1 +
1 file changed, 1 insertion(+)
diff -- a/include/linux/spi/spi.h b/include/linux/spi/spi.h
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -453,6 +453,7 @@ extern struct spi_device *spi_new_ancill
* @last_cs_mode_high: was (mode & SPI_CS_HIGH) true on the last call to set_cs.
* @last_cs: the last chip_select that is recorded by set_cs, -1 on non chip
* selected
+ * @last_cs_index_mask: bit mask the last chip selects that were used
* @xfer_completion: used by core transfer_one_message()
* @busy: message pump is busy
* @running: message pump is running
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: spi.h: add missing kernel-doc for @last_cs_index_mask
2024-03-28 4:38 [PATCH] spi: spi.h: add missing kernel-doc for @last_cs_index_mask Randy Dunlap
@ 2024-03-28 8:51 ` Andy Shevchenko
2024-03-28 22:33 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-03-28 8:51 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Mark Brown, Andy Shevchenko, linux-spi
On Thu, Mar 28, 2024 at 6:38 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> kernel-doc complains about last_cs_index_mask not described, so add its
> decscription.
description
> spi.h:778: warning: Function parameter or struct member 'last_cs_index_mask' not described in 'spi_controller'
Do we need a Fixes tag?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: spi.h: add missing kernel-doc for @last_cs_index_mask
2024-03-28 8:51 ` Andy Shevchenko
@ 2024-03-28 22:33 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-03-28 22:33 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, Mark Brown, Andy Shevchenko, linux-spi
On 3/28/24 01:51, Andy Shevchenko wrote:
> On Thu, Mar 28, 2024 at 6:38 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> kernel-doc complains about last_cs_index_mask not described, so add its
>> decscription.
>
> description
Fixed in v2.
>> spi.h:778: warning: Function parameter or struct member 'last_cs_index_mask' not described in 'spi_controller'
>
> Do we need a Fixes tag?
I'll add one.
Thanks.
--
#Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-28 22:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-28 4:38 [PATCH] spi: spi.h: add missing kernel-doc for @last_cs_index_mask Randy Dunlap
2024-03-28 8:51 ` Andy Shevchenko
2024-03-28 22:33 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).