linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Alvin Šipraga" <alvin@pqrs.dk>
Cc: "Mark Brown" <broonie@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Alvin Šipraga" <alsi@bang-olufsen.dk>
Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,sc18is602: convert binding to YAML
Date: Tue, 23 Apr 2024 10:13:21 -0500	[thread overview]
Message-ID: <20240423151321.GA273010-robh@kernel.org> (raw)
In-Reply-To: <20240423-sc18is606-v1-1-094ef37d5a59@bang-olufsen.dk>

On Tue, Apr 23, 2024 at 01:35:30PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> Convert the txt binding to YAML. In the example, the node name was
> changed from sc18is603@28 to spi@28 to conform with the standard
> $nodename property in the spi-controller.yaml schema.
> 
> Make myself maintainer of this binding, since nobody else has
> volunteered themselves.
> 
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
>  .../devicetree/bindings/spi/nxp,sc18is602.yaml     | 59 ++++++++++++++++++++++
>  .../devicetree/bindings/spi/spi-sc18is602.txt      | 23 ---------
>  2 files changed, 59 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/nxp,sc18is602.yaml b/Documentation/devicetree/bindings/spi/nxp,sc18is602.yaml
> new file mode 100644
> index 000000000000..5b34fdf6148a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/nxp,sc18is602.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/nxp,sc18is602.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP SC18IS602/602B/603 I2C to SPI bridge
> +
> +maintainers:
> +  - Alvin Šipraga <alsi@bang-olufsen.dk>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,sc18is602
> +      - nxp,sc18is602b
> +      - nxp,sc18is603
> +
> +  reg:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    $ref: /schemas/types.yaml#/definitions/uint32

Drop. 'clock-frequency' already has a type. With that,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

  reply	other threads:[~2024-04-23 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 11:35 [PATCH 0/3] spi: sc18is602: add support for SC18IS606 Alvin Šipraga
2024-04-23 11:35 ` [PATCH 1/3] spi: dt-bindings: nxp,sc18is602: convert binding to YAML Alvin Šipraga
2024-04-23 15:13   ` Rob Herring [this message]
2024-04-23 11:35 ` [PATCH 2/3] spi: dt-bindings: nxp,sc18is602: add compatible for SC18IS606 Alvin Šipraga
2024-04-23 15:15   ` Rob Herring
2024-04-23 11:35 ` [PATCH 3/3] spi: sc18is602: add support " Alvin Šipraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240423151321.GA273010-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alsi@bang-olufsen.dk \
    --cc=alvin@pqrs.dk \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).