From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: [PATCH v1 06/10] spi: pxa2xx: Remove duplicate check
Date: Fri, 17 May 2024 22:47:40 +0300 [thread overview]
Message-ID: <20240517195344.813032-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240517195344.813032-1-andriy.shevchenko@linux.intel.com>
The mmio_base can't be NULL at this point. It's either checked
in both pxa_ssp_probe() and pxa2xx_spi_init_ssp() or correctly
provided by PCI core. Hence, remove duplicate check which is
a dead code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-pxa2xx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 6bbeb1d09ed9..cd28b798b53b 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1417,9 +1417,6 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
if (!ssp)
ssp = &platform_info->ssp;
- if (!ssp->mmio_base)
- return dev_err_probe(dev, -ENODEV, "failed to get SSP\n");
-
if (platform_info->is_target)
controller = devm_spi_alloc_target(dev, sizeof(*drv_data));
else
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-05-17 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 19:47 [PATCH v1 00/10] spi: pxa2xx: Get rid of an additional layer in PCI driver Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 01/10] spi: pxa2xx: Reorganize the SSP type retrieval Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 02/10] spi: pxa2xx: Remove no more needed driver data Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 03/10] spi: pxa2xx: Remove hard coded number of chip select pins Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 04/10] spi: pxa2xx: Utilise temporary variable for struct device Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 05/10] spi: pxa2xx: Print DMA burst size only when DMA is enabled Andy Shevchenko
2024-05-17 19:47 ` Andy Shevchenko [this message]
2024-05-17 19:47 ` [PATCH v1 07/10] spi: pxa2xx: Remove superflous check for Intel Atom SoCs Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 08/10] spi: pxa2xx: Extract pxa2xx_spi_platform_*() callbacks Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 09/10] spi: pxa2xx: Move platform driver to a separate file Andy Shevchenko
2024-05-17 20:36 ` Andy Shevchenko
2024-05-17 19:47 ` [PATCH v1 10/10] spi: pxa2xx: Convert PCI driver to use spi-pxa2xx code directly Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517195344.813032-7-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).