linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v1 1/1] spi: pxa2xx: Move PXA SSP bindings to the correct folder
Date: Mon, 20 May 2024 15:36:00 -0500	[thread overview]
Message-ID: <20240520203600.GA1424819-robh@kernel.org> (raw)
In-Reply-To: <ZksqPiSLY8OlE5lT@smile.fi.intel.com>

On Mon, May 20, 2024 at 01:47:26PM +0300, Andy Shevchenko wrote:
> On Fri, May 17, 2024 at 03:19:51PM -0500, Rob Herring wrote:
> > On Fri, May 17, 2024 at 2:58 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Fri, May 17, 2024 at 06:24:37PM +0100, Mark Brown wrote:
> > > > On Fri, May 17, 2024 at 08:11:03PM +0300, Andy Shevchenko wrote:
> 
> ...
> 
> > > > > SSP stands for Serial Synchronous Protocol and has nothing to do with
> > > > > UART, also known as USART, where 'A' stands for Asynchronous.
> > > > >
> > > > > Move the SSP bindings to where it belongs.
> > > >
> > > > It's a serial device which is also used for other applications (the
> > > > other one upstream being audio) so I can see where the current binding
> > > > comes from and it's not super obvious that spi is especially better
> > > > here.
> > >
> > > Hmm... okay. Then it's question to DT people. Consider this as a report.
> > > Because UART (aka serial) is definitely not the place for SPI/SSP bindings
> > > either.
> > 
> > Move it when it is converted.
> 
> The problem is that somebody added a binding (in YAML) for SPI PXA2xx
> in the spi/ folder while this one kept unconverted.

Ah, well that detail was missed.

> 
> If it dangles more, it might be that we will have two asynchronous bindings
> for the co-existed drivers.

Looks like all that is needed is adding the compatible strings and 
'dmas' property to spi/marvell,mmp2-ssp.yaml. The examples in the old 
binding have other stuff, but looks like that's garbage.

Rob

  reply	other threads:[~2024-05-20 20:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 17:11 [PATCH v1 1/1] spi: pxa2xx: Move PXA SSP bindings to the correct folder Andy Shevchenko
2024-05-17 17:24 ` Mark Brown
2024-05-17 19:58   ` Andy Shevchenko
2024-05-17 20:19     ` Rob Herring
2024-05-20 10:47       ` Andy Shevchenko
2024-05-20 20:36         ` Rob Herring [this message]
2024-05-21 14:02           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520203600.GA1424819-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).