From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E54BDD27A; Mon, 20 May 2024 20:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716237362; cv=none; b=tuqb323tmLAJ+CtgrZUZ+Tb12cUZeNzYCReeQhTBc3/jhdHHKG/lntly5QDBjuv5rcKB6FTm7X4vmz+8/jNf5St2kQ+wTjCzGDaMwovBq+fqva44SiyXauuqYf0jb73KeONmBXa6tD3Z4Une2C/zZkrJ2boeWH9N64g/j8Ifqkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716237362; c=relaxed/simple; bh=e/tOP5Sek+faG3xsBh/Yz8zOqx//+Q/9hHUwA35OWAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OGWipimwLaMfX4Tylc0ODgFVJmb23jzP7sZANhoNgg6y3b41/H7WVLkPzo2sd2kKioKtQF7RcXt79HG5kN/JRU4HY26U5fgkItF+NdvGfeG+MkxhdBL3npIdlwXGx8XSipHD8LNL87LfL3V4ImlH/i2lL0yT0K18OxF2AQ14ABk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aAip3esm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aAip3esm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 834C1C2BD10; Mon, 20 May 2024 20:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716237361; bh=e/tOP5Sek+faG3xsBh/Yz8zOqx//+Q/9hHUwA35OWAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aAip3esmRhJut2sxDJQe0/veutbOVefJHqUqW0i7oFpw0bPlhtOQI/e4EPD3iSliJ OVUmJQ153eQyiGv0wrrIvZ1ioKJkjIfy1wutTbYBBL6g7w0K8abNhoB6rkPtHkcT4w GeKZ8COhG/WAPVpwsqaUrPaV5d5GSVDpla2eQ2FGkR6YFbomvG4bCmZtSXB197+umS k2GQdRvZS2iGl/Qtc8fXI6kncG3S2vzeyU88jDm8vBtOggCPDlka4LhNq7QwUEJyKY UPerCe9+qsDKlF8h6b4V7w0rAywtVM0XAymwJcDCtAe1Bmoluc4Ugs8AXBHcTske9t UPR3mAgl3rmUA== Date: Mon, 20 May 2024 15:36:00 -0500 From: Rob Herring To: Andy Shevchenko Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v1 1/1] spi: pxa2xx: Move PXA SSP bindings to the correct folder Message-ID: <20240520203600.GA1424819-robh@kernel.org> References: <20240517171103.221856-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, May 20, 2024 at 01:47:26PM +0300, Andy Shevchenko wrote: > On Fri, May 17, 2024 at 03:19:51PM -0500, Rob Herring wrote: > > On Fri, May 17, 2024 at 2:58 PM Andy Shevchenko > > wrote: > > > On Fri, May 17, 2024 at 06:24:37PM +0100, Mark Brown wrote: > > > > On Fri, May 17, 2024 at 08:11:03PM +0300, Andy Shevchenko wrote: > > ... > > > > > > SSP stands for Serial Synchronous Protocol and has nothing to do with > > > > > UART, also known as USART, where 'A' stands for Asynchronous. > > > > > > > > > > Move the SSP bindings to where it belongs. > > > > > > > > It's a serial device which is also used for other applications (the > > > > other one upstream being audio) so I can see where the current binding > > > > comes from and it's not super obvious that spi is especially better > > > > here. > > > > > > Hmm... okay. Then it's question to DT people. Consider this as a report. > > > Because UART (aka serial) is definitely not the place for SPI/SSP bindings > > > either. > > > > Move it when it is converted. > > The problem is that somebody added a binding (in YAML) for SPI PXA2xx > in the spi/ folder while this one kept unconverted. Ah, well that detail was missed. > > If it dangles more, it might be that we will have two asynchronous bindings > for the co-existed drivers. Looks like all that is needed is adding the compatible strings and 'dmas' property to spi/marvell,mmp2-ssp.yaml. The examples in the old binding have other stuff, but looks like that's garbage. Rob