From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: [PATCH v2 09/11] spi: pxa2xx: Extract pxa2xx_spi_platform_*() callbacks
Date: Thu, 30 May 2024 18:10:05 +0300 [thread overview]
Message-ID: <20240530151117.1130792-10-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240530151117.1130792-1-andriy.shevchenko@linux.intel.com>
In preparation of the extracting platform driver from spi-pxa2xx.c
split the probe and remove functions so we have bus independent
and platform device ones.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-pxa2xx.c | 52 +++++++++++++++++++++++++---------------
1 file changed, 33 insertions(+), 19 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 3c03a8cd9ee6..74f242e652df 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1413,30 +1413,16 @@ static size_t pxa2xx_spi_max_dma_transfer_size(struct spi_device *spi)
return MAX_DMA_LEN;
}
-static int pxa2xx_spi_probe(struct platform_device *pdev)
+static int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp)
{
- struct device *dev = &pdev->dev;
struct pxa2xx_spi_controller *platform_info;
struct spi_controller *controller;
struct driver_data *drv_data;
- struct ssp_device *ssp;
const struct lpss_config *config;
int status;
u32 tmp;
platform_info = dev_get_platdata(dev);
- if (!platform_info) {
- platform_info = pxa2xx_spi_init_pdata(pdev);
- if (IS_ERR(platform_info))
- return dev_err_probe(dev, PTR_ERR(platform_info), "missing platform data\n");
- }
-
- ssp = pxa2xx_spi_ssp_request(pdev);
- if (IS_ERR(ssp))
- return PTR_ERR(ssp);
- if (!ssp)
- ssp = &platform_info->ssp;
-
if (platform_info->is_target)
controller = devm_spi_alloc_target(dev, sizeof(*drv_data));
else
@@ -1628,9 +1614,8 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
return status;
}
-static void pxa2xx_spi_remove(struct platform_device *pdev)
+static void pxa2xx_spi_remove(struct device *dev)
{
- struct device *dev = &pdev->dev;
struct driver_data *drv_data = dev_get_drvdata(dev);
struct ssp_device *ssp = drv_data->ssp;
@@ -1708,6 +1693,35 @@ static const struct dev_pm_ops pxa2xx_spi_pm_ops = {
RUNTIME_PM_OPS(pxa2xx_spi_runtime_suspend, pxa2xx_spi_runtime_resume, NULL)
};
+static int pxa2xx_spi_platform_probe(struct platform_device *pdev)
+{
+ struct pxa2xx_spi_controller *platform_info;
+ struct device *dev = &pdev->dev;
+ struct ssp_device *ssp;
+
+ platform_info = dev_get_platdata(dev);
+ if (!platform_info) {
+ platform_info = pxa2xx_spi_init_pdata(pdev);
+ if (IS_ERR(platform_info))
+ return dev_err_probe(dev, PTR_ERR(platform_info), "missing platform data\n");
+
+ dev->platform_data = platform_info;
+ }
+
+ ssp = pxa2xx_spi_ssp_request(pdev);
+ if (IS_ERR(ssp))
+ return PTR_ERR(ssp);
+ if (!ssp)
+ ssp = &platform_info->ssp;
+
+ return pxa2xx_spi_probe(dev, ssp);
+}
+
+static void pxa2xx_spi_platform_remove(struct platform_device *pdev)
+{
+ pxa2xx_spi_remove(&pdev->dev);
+}
+
static const struct acpi_device_id pxa2xx_spi_acpi_match[] = {
{ "80860F0E" },
{ "8086228E" },
@@ -1732,8 +1746,8 @@ static struct platform_driver driver = {
.acpi_match_table = pxa2xx_spi_acpi_match,
.of_match_table = pxa2xx_spi_of_match,
},
- .probe = pxa2xx_spi_probe,
- .remove_new = pxa2xx_spi_remove,
+ .probe = pxa2xx_spi_platform_probe,
+ .remove_new = pxa2xx_spi_platform_remove,
};
static int __init pxa2xx_spi_init(void)
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-05-30 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 15:09 [PATCH v2 00/11] spi: pxa2xx: Get rid of an additional layer in PCI driver Andy Shevchenko
2024-05-30 15:09 ` [PATCH v2 01/11] spi: pxa2xx: Wrap pxa_ssp_request() to be device managed resource Andy Shevchenko
2024-05-30 15:09 ` [PATCH v2 02/11] spi: pxa2xx: Reorganize the SSP type retrieval Andy Shevchenko
2024-05-30 15:09 ` [PATCH v2 03/11] spi: pxa2xx: Remove no more needed driver data Andy Shevchenko
2024-05-30 15:10 ` [PATCH v2 04/11] spi: pxa2xx: Remove hard coded number of chip select pins Andy Shevchenko
2024-05-30 15:10 ` [PATCH v2 05/11] spi: pxa2xx: Utilise temporary variable for struct device Andy Shevchenko
2024-05-30 15:10 ` [PATCH v2 06/11] spi: pxa2xx: Print DMA burst size only when DMA is enabled Andy Shevchenko
2024-05-30 15:10 ` [PATCH v2 07/11] spi: pxa2xx: Remove duplicate check Andy Shevchenko
2024-05-30 15:10 ` [PATCH v2 08/11] spi: pxa2xx: Remove superflous check for Intel Atom SoCs Andy Shevchenko
2024-05-30 15:10 ` Andy Shevchenko [this message]
2024-05-30 15:10 ` [PATCH v2 10/11] spi: pxa2xx: Move platform driver to a separate file Andy Shevchenko
2024-05-30 15:10 ` [PATCH v2 11/11] spi: pxa2xx: Convert PCI driver to use spi-pxa2xx code directly Andy Shevchenko
2024-06-05 21:38 ` [PATCH v2 00/11] spi: pxa2xx: Get rid of an additional layer in PCI driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530151117.1130792-10-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).