From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: [PATCH v1 1/2] spi: Revert "Check if transfer is mapped before calling DMA sync APIs"
Date: Fri, 31 May 2024 12:44:32 +0300 [thread overview]
Message-ID: <20240531094658.1598969-2-andy.shevchenko@gmail.com> (raw)
In-Reply-To: <20240531094658.1598969-1-andy.shevchenko@gmail.com>
This reverts commit da560097c05612f8d360f86528f6213629b9c395.
It makes no difference as it was mistakenly thought that it fixes
a bug while another unnoticed change have been preserved in the
tester's repositorory.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/spi/spi.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 9bc9fd10d538..43cd3e5bccbe 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1320,7 +1320,7 @@ static int __spi_unmap_msg(struct spi_controller *ctlr, struct spi_message *msg)
return 0;
}
-static void spi_dma_sync_for_device(struct spi_controller *ctlr, struct spi_message *msg,
+static void spi_dma_sync_for_device(struct spi_controller *ctlr,
struct spi_transfer *xfer)
{
struct device *rx_dev = ctlr->cur_rx_dma_dev;
@@ -1329,14 +1329,11 @@ static void spi_dma_sync_for_device(struct spi_controller *ctlr, struct spi_mess
if (!ctlr->cur_msg_mapped)
return;
- if (!ctlr->can_dma(ctlr, msg->spi, xfer))
- return;
-
dma_sync_sgtable_for_device(tx_dev, &xfer->tx_sg, DMA_TO_DEVICE);
dma_sync_sgtable_for_device(rx_dev, &xfer->rx_sg, DMA_FROM_DEVICE);
}
-static void spi_dma_sync_for_cpu(struct spi_controller *ctlr, struct spi_message *msg,
+static void spi_dma_sync_for_cpu(struct spi_controller *ctlr,
struct spi_transfer *xfer)
{
struct device *rx_dev = ctlr->cur_rx_dma_dev;
@@ -1345,9 +1342,6 @@ static void spi_dma_sync_for_cpu(struct spi_controller *ctlr, struct spi_message
if (!ctlr->cur_msg_mapped)
return;
- if (!ctlr->can_dma(ctlr, msg->spi, xfer))
- return;
-
dma_sync_sgtable_for_cpu(rx_dev, &xfer->rx_sg, DMA_FROM_DEVICE);
dma_sync_sgtable_for_cpu(tx_dev, &xfer->tx_sg, DMA_TO_DEVICE);
}
@@ -1365,13 +1359,11 @@ static inline int __spi_unmap_msg(struct spi_controller *ctlr,
}
static void spi_dma_sync_for_device(struct spi_controller *ctrl,
- struct spi_message *msg,
struct spi_transfer *xfer)
{
}
static void spi_dma_sync_for_cpu(struct spi_controller *ctrl,
- struct spi_message *msg,
struct spi_transfer *xfer)
{
}
@@ -1643,10 +1635,10 @@ static int spi_transfer_one_message(struct spi_controller *ctlr,
reinit_completion(&ctlr->xfer_completion);
fallback_pio:
- spi_dma_sync_for_device(ctlr, msg, xfer);
+ spi_dma_sync_for_device(ctlr, xfer);
ret = ctlr->transfer_one(ctlr, msg->spi, xfer);
if (ret < 0) {
- spi_dma_sync_for_cpu(ctlr, msg, xfer);
+ spi_dma_sync_for_cpu(ctlr, xfer);
if (ctlr->cur_msg_mapped &&
(xfer->error & SPI_TRANS_FAIL_NO_START)) {
@@ -1671,7 +1663,7 @@ static int spi_transfer_one_message(struct spi_controller *ctlr,
msg->status = ret;
}
- spi_dma_sync_for_cpu(ctlr, msg, xfer);
+ spi_dma_sync_for_cpu(ctlr, xfer);
} else {
if (xfer->len)
dev_err(&msg->spi->dev,
--
2.45.1
next prev parent reply other threads:[~2024-05-31 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 9:44 [PATCH v1 0/2] spi: Make dummy SG handling robust Andy Shevchenko
2024-05-31 9:44 ` Andy Shevchenko [this message]
2024-05-31 12:15 ` [PATCH v1 1/2] spi: Revert "Check if transfer is mapped before calling DMA sync APIs" Mark Brown
2024-05-31 13:10 ` Andy Shevchenko
2024-05-31 9:44 ` [PATCH v1 2/2] spi: Do not rely on the SG table and respective API implementations Andy Shevchenko
2024-05-31 14:37 ` [PATCH v1 0/2] spi: Make dummy SG handling robust Nícolas F. R. A. Prado
2024-05-31 15:46 ` Andy Shevchenko
2024-05-31 15:51 ` Andy Shevchenko
2024-05-31 17:14 ` Nícolas F. R. A. Prado
2024-05-31 21:45 ` Andy Shevchenko
2024-05-31 21:59 ` Nícolas F. R. A. Prado
2024-06-03 12:26 ` Mark Brown
2024-06-03 17:37 ` Nícolas F. R. A. Prado
2024-06-03 17:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531094658.1598969-2-andy.shevchenko@gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).