From: Eddie James <eajames@linux.ibm.com>
To: linux-fsi@lists.ozlabs.org
Cc: eajames@linux.ibm.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
broonie@kernel.org, andi.shyti@kernel.org, joel@jms.id.au,
alistair@popple.id.au, jk@ozlabs.org,
andrew@codeconstruct.com.au, linux-aspeed@lists.ozlabs.org,
ninad@linux.ibm.com, lakshmiy@us.ibm.com
Subject: [PATCH v4 38/40] spi: fsi: Calculate clock divider from local bus frequency
Date: Wed, 5 Jun 2024 16:23:10 -0500 [thread overview]
Message-ID: <20240605212312.349188-39-eajames@linux.ibm.com> (raw)
In-Reply-To: <20240605212312.349188-1-eajames@linux.ibm.com>
Use the new FSI device local bus clock to calculate the proper SPI
clock divider.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Acked-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-fsi.c | 33 ++++++++++++++++++++++++++++++---
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c
index fc9e33be1e0e7..e762690f1a390 100644
--- a/drivers/spi/spi-fsi.c
+++ b/drivers/spi/spi-fsi.c
@@ -40,6 +40,7 @@
#define SPI_FSI_CLOCK_CFG_SCK_RECV_DEL GENMASK_ULL(51, 44)
#define SPI_FSI_CLOCK_CFG_SCK_NO_DEL BIT_ULL(51)
#define SPI_FSI_CLOCK_CFG_SCK_DIV GENMASK_ULL(63, 52)
+#define SPI_FSI_CLOCK_CFG_SCK_DIV_MIN 0x4
#define SPI_FSI_MMAP 0x4
#define SPI_FSI_DATA_TX 0x5
#define SPI_FSI_DATA_RX 0x6
@@ -70,6 +71,7 @@
struct fsi2spi {
struct fsi_device *fsi; /* FSI2SPI CFAM engine device */
struct mutex lock; /* lock access to the device */
+ u32 lbus_freq;
};
struct fsi_spi {
@@ -359,7 +361,7 @@ static int fsi_spi_transfer_data(struct fsi_spi *ctx,
return 0;
}
-static int fsi_spi_transfer_init(struct fsi_spi *ctx)
+static int fsi_spi_transfer_init(struct fsi_spi *ctx, u32 clock_div)
{
int loops = 0;
int rc;
@@ -370,7 +372,7 @@ static int fsi_spi_transfer_init(struct fsi_spi *ctx)
u64 status = 0ULL;
u64 wanted_clock_cfg = SPI_FSI_CLOCK_CFG_ECC_DISABLE |
SPI_FSI_CLOCK_CFG_SCK_NO_DEL |
- FIELD_PREP(SPI_FSI_CLOCK_CFG_SCK_DIV, 19);
+ FIELD_PREP(SPI_FSI_CLOCK_CFG_SCK_DIV, clock_div);
end = jiffies + msecs_to_jiffies(SPI_FSI_TIMEOUT_MS);
do {
@@ -421,6 +423,24 @@ static int fsi_spi_transfer_init(struct fsi_spi *ctx)
return rc;
}
+static u32 fsi_spi_calculate_clock_div(struct fsi2spi *bridge, struct spi_device *dev,
+ struct spi_transfer *transfer)
+{
+ u32 div = 19;
+
+ if (bridge->lbus_freq) {
+ u32 desired_speed_hz = transfer->speed_hz ?: dev->max_speed_hz;
+
+ div = DIV_ROUND_UP(bridge->lbus_freq, desired_speed_hz);
+ if (div < SPI_FSI_CLOCK_CFG_SCK_DIV_MIN)
+ div = SPI_FSI_CLOCK_CFG_SCK_DIV_MIN;
+
+ transfer->effective_speed_hz = bridge->lbus_freq / div;
+ }
+
+ return div;
+}
+
static int fsi_spi_transfer_one_message(struct spi_controller *ctlr,
struct spi_message *mesg)
{
@@ -429,6 +449,7 @@ static int fsi_spi_transfer_one_message(struct spi_controller *ctlr,
unsigned int len;
struct spi_transfer *transfer;
struct fsi_spi *ctx = spi_controller_get_devdata(ctlr);
+ u32 div;
rc = fsi_spi_check_mux(ctx->bridge->fsi, ctx->dev);
if (rc)
@@ -446,7 +467,8 @@ static int fsi_spi_transfer_one_message(struct spi_controller *ctlr,
dev_dbg(ctx->dev, "Start tx of %d bytes.\n", transfer->len);
- rc = fsi_spi_transfer_init(ctx);
+ div = fsi_spi_calculate_clock_div(ctx->bridge, mesg->spi, transfer);
+ rc = fsi_spi_transfer_init(ctx, div);
if (rc < 0)
goto error;
@@ -533,6 +555,7 @@ static int fsi_spi_probe(struct device *dev)
bridge->fsi = fsi;
mutex_init(&bridge->lock);
+ bridge->lbus_freq = fsi_device_local_bus_frequency(fsi);
for_each_available_child_of_node(dev->of_node, np) {
u32 base;
@@ -550,6 +573,10 @@ static int fsi_spi_probe(struct device *dev)
ctlr->dev.of_node = np;
ctlr->num_chipselect = of_get_available_child_count(np) ?: 1;
+ if (bridge->lbus_freq) {
+ ctlr->min_speed_hz = DIV_ROUND_UP(bridge->lbus_freq, 0xfff);
+ ctlr->max_speed_hz = bridge->lbus_freq / SPI_FSI_CLOCK_CFG_SCK_DIV_MIN;
+ }
ctlr->flags = SPI_CONTROLLER_HALF_DUPLEX;
ctlr->max_transfer_size = fsi_spi_max_transfer_size;
ctlr->transfer_one_message = fsi_spi_transfer_one_message;
--
2.39.3
next prev parent reply other threads:[~2024-06-05 21:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 21:22 [PATCH v4 00/40] fsi: Add interrupt support Eddie James
2024-06-05 21:22 ` [PATCH v4 01/40] fsi: hub: Set master index to link number plus one Eddie James
2024-06-05 21:22 ` [PATCH v4 02/40] fsi: Move slave definitions to fsi-slave.h Eddie James
2024-06-05 21:22 ` [PATCH v4 03/40] fsi: Fix slave addressing after break command Eddie James
2024-06-05 21:22 ` [PATCH v4 04/40] fsi: Use a defined value for default echo delay Eddie James
2024-06-05 21:22 ` [PATCH v4 05/40] fsi: Calculate local bus clock frequency Eddie James
2024-06-05 21:22 ` [PATCH v4 06/40] fsi: core: Improve master read/write/error traces Eddie James
2024-06-05 21:22 ` [PATCH v4 07/40] fsi: core: Add slave error trace Eddie James
2024-06-05 21:22 ` [PATCH v4 08/40] fsi: core: Reset errors instead of clearing interrupts Eddie James
2024-06-05 21:22 ` [PATCH v4 09/40] fsi: aspeed: Add AST2700 support Eddie James
2024-06-05 21:22 ` [PATCH v4 10/40] fsi: core: Add slave spinlock Eddie James
2024-06-05 21:22 ` [PATCH v4 11/40] fsi: core: Allow cfam device type aliases Eddie James
2024-06-05 21:22 ` [PATCH v4 12/40] fsi: core: Add common regmap master functions Eddie James
2024-06-05 21:22 ` [PATCH v4 13/40] fsi: core: Disable relative addressing during scan Eddie James
2024-06-05 21:22 ` [PATCH v4 14/40] fsi: hub: Use common initialization and link enable Eddie James
2024-06-05 21:22 ` [PATCH v4 15/40] fsi: aspeed: " Eddie James
2024-06-05 21:22 ` [PATCH v4 16/40] fsi: aspeed: Remove cfam reset sysfs file in error path and remove Eddie James
2024-06-05 21:22 ` [PATCH v4 17/40] fsi: aspeed: Refactor trace functions Eddie James
2024-06-05 21:22 ` [PATCH v4 18/40] fsi: aspeed: Don't clear all IRQs during OPB transfers Eddie James
2024-06-05 21:22 ` [PATCH v4 19/40] fsi: aspeed: Only read result register for successful read Eddie James
2024-06-05 21:22 ` [PATCH v4 20/40] fsi: aspeed: Switch to spinlock Eddie James
2024-06-05 21:22 ` [PATCH v4 21/40] fsi: aspeed: Disable relative addressing and IPOLL for cfam reset Eddie James
2024-06-05 21:22 ` [PATCH v4 22/40] fsi: aspeed: Use common master error handler Eddie James
2024-06-05 21:22 ` [PATCH v4 23/40] fsi: core: Add interrupt support Eddie James
2024-06-05 21:22 ` [PATCH v4 24/40] fsi: aspeed: " Eddie James
2024-06-05 21:22 ` [PATCH v4 25/40] fsi: hub: " Eddie James
2024-06-05 21:22 ` [PATCH v4 26/40] i2c: fsi: Calculate clock divider from local bus frequency Eddie James
2024-06-05 21:22 ` [PATCH v4 27/40] i2c: fsi: Improve formatting Eddie James
2024-06-05 21:23 ` [PATCH v4 28/40] i2c: fsi: Change fsi_i2c_write_reg to accept data instead of a pointer Eddie James
2024-06-05 21:23 ` [PATCH v4 29/40] i2c: fsi: Remove list structure of ports Eddie James
2024-06-05 21:23 ` [PATCH v4 30/40] i2c: fsi: Define a function to check status error bits Eddie James
2024-06-05 21:23 ` [PATCH v4 31/40] i2c: fsi: Add boolean for skip stop command on abort Eddie James
2024-06-05 21:23 ` [PATCH v4 32/40] i2c: fsi: Add interrupt support Eddie James
2024-06-05 21:23 ` [PATCH v4 33/40] fsi: hub master: Reset hub master after errors Eddie James
2024-06-05 21:23 ` [PATCH v4 34/40] fsi: core: Add master register read-only sysfs Eddie James
2024-06-05 21:23 ` [PATCH v4 35/40] fsi: core: Add slave " Eddie James
2024-06-05 21:23 ` [PATCH v4 36/40] fsi: i2cr: Adjust virtual CFAM ID to match Odyssey chip Eddie James
2024-06-05 21:23 ` [PATCH v4 37/40] fsi: core: Add different types of CFAM Eddie James
2024-06-05 21:23 ` Eddie James [this message]
2024-06-05 21:23 ` [PATCH v4 39/40] ARM: dts: aspeed: P10 and tacoma: Set FSI clock frequency Eddie James
2024-06-05 21:23 ` [PATCH v4 40/40] ARM: dts: aspeed: P10: Bump SPI max frequencies Eddie James
2024-06-06 1:02 ` [PATCH v4 00/40] fsi: Add interrupt support Andrew Jeffery
2024-07-01 15:29 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605212312.349188-39-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=alistair@popple.id.au \
--cc=andi.shyti@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=broonie@kernel.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=lakshmiy@us.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ninad@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).