From: Conor Dooley <conor@kernel.org>
To: linux-mmc@vger.kernel.org
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
cyril.jean@microchip.com, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: [RFC v1 0/3] mmc-spi - support controllers incapable of getting as low as 400KHz
Date: Wed, 12 Jun 2024 16:48:30 +0100 [thread overview]
Message-ID: <20240612-brigade-shell-1f626e7e592f@spud> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
Yo,
RFC for some stuff that I've got in-progress for a customer's board
where they want to use mmc-spi-slot with a QSPI controller that is
incapable of getting as low as 400KHz with the way clocks have been
configured on the system. At the moment, if a controller cannot get that
low, linux continuously reports that queuing a transfer fails. The first
couple of transfers will complete on this system, until mmc_start_host()
kicks in and clamps the frequency to the larger of host->f_min and 400
KHz.
Doing something like patch 1 of this set would allow the mmc-spi-slot to
function for some sd cards, an improvement on the current none. I don't
have any sd cards on hand that don't support the 5 MHz minimum frequency
that this controller is limited to, so I amn't sure at what point this
will blow up if such a card was used.
Is this sort of change something that would fly?
Patches 2 & 3 are just here b/c without #3 the qspi driver for this
platform doesn't support anything other than mem ops and #2 is required
to set the minimum frequency for mmc_spi to pick up.
Cheers,
Conor.
CC: Ulf Hansson <ulf.hansson@linaro.org>
CC: Conor Dooley <conor.dooley@microchip.com>
CC: cyril.jean@microchip.com
CC: Mark Brown <broonie@kernel.org>
CC: linux-mmc@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-riscv@lists.infradead.org
CC: linux-spi@vger.kernel.org
Conor Dooley (2):
mmc: mmc_spi: allow for spi controllers incapable of getting as low as
400k
spi: microchip-core-qspi: set min_speed_hz during probe
Cyril Jean (1):
spi: microchip-core-qspi: Add regular transfers
drivers/mmc/host/mmc_spi.c | 5 +-
drivers/spi/spi-microchip-core-qspi.c | 224 +++++++++++++++++++++++++-
2 files changed, 226 insertions(+), 3 deletions(-)
--
2.43.0
next reply other threads:[~2024-06-12 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:48 Conor Dooley [this message]
2024-06-12 15:48 ` [RFC v1 1/3] mmc: mmc_spi: allow for spi controllers incapable of getting as low as 400k Conor Dooley
2024-06-20 12:50 ` Ulf Hansson
2024-06-20 14:12 ` Conor Dooley
2024-06-20 14:24 ` Ulf Hansson
2024-06-12 15:48 ` [RFC v1 2/3] spi: microchip-core-qspi: Add regular transfers Conor Dooley
2024-06-12 16:40 ` Mark Brown
2024-06-12 20:48 ` Conor Dooley
2024-06-19 11:18 ` Conor Dooley
2024-06-12 15:48 ` [RFC v1 3/3] spi: microchip-core-qspi: set min_speed_hz during probe Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612-brigade-shell-1f626e7e592f@spud \
--to=conor@kernel.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=cyril.jean@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).