From: Witold Sadowski <wsadowski@marvell.com>
To: <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <broonie@kernel.org>, <robh@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<pthombar@cadence.com>, Witold Sadowski <wsadowski@marvell.com>,
"Piyush Malgujar" <pmalgujar@marvell.com>
Subject: [PATCH v9 8/9] spi: cadence: Change cs property reading.
Date: Wed, 19 Jun 2024 07:17:14 -0700 [thread overview]
Message-ID: <20240619141716.1785467-9-wsadowski@marvell.com> (raw)
In-Reply-To: <20240619141716.1785467-1-wsadowski@marvell.com>
In current implementation cs property can be read only from
device-tree(for_each_available_child_of_node_scoped). Change it to fwnode
based read to allow property reading in ACPI case too.
Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>
---
drivers/spi/spi-cadence-xspi.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c
index 9cf3624595ea..4edac7c8d73c 100644
--- a/drivers/spi/spi-cadence-xspi.c
+++ b/drivers/spi/spi-cadence-xspi.c
@@ -811,15 +811,20 @@ static irqreturn_t cdns_xspi_irq_handler(int this_irq, void *dev)
static int cdns_xspi_of_get_plat_data(struct platform_device *pdev)
{
- struct device_node *node_prop = pdev->dev.of_node;
+ struct fwnode_handle *fwnode_child;
unsigned int cs;
- for_each_available_child_of_node_scoped(node_prop, node_child) {
- if (of_property_read_u32(node_child, "reg", &cs)) {
+ device_for_each_child_node(&pdev->dev, fwnode_child) {
+ if (!fwnode_device_is_available(fwnode_child))
+ continue;
+
+ if (fwnode_property_read_u32(fwnode_child, "reg", &cs)) {
dev_err(&pdev->dev, "Couldn't get memory chip select\n");
+ fwnode_handle_put(fwnode_child);
return -ENXIO;
} else if (cs >= CDNS_XSPI_MAX_BANKS) {
dev_err(&pdev->dev, "reg (cs) parameter value too large\n");
+ fwnode_handle_put(fwnode_child);
return -ENXIO;
}
}
--
2.43.0
next prev parent reply other threads:[~2024-06-19 14:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 14:17 [PATCH v9 0/9] Marvell HW overlay support for Cadence xSPI Witold Sadowski
2024-06-19 14:17 ` [PATCH v9 1/9] spi: dt-bindings: cadence: Add Marvell overlay bindings documentation for Cadence XSPI Witold Sadowski
2024-06-19 14:17 ` [PATCH v9 2/9] spi: cadence: Add static PHY configuration in Marvell overlay Witold Sadowski
2024-06-19 14:17 ` [PATCH v9 3/9] spi: cadence: Add clock configuration for Marvell xSPI overlay Witold Sadowski
2024-06-19 14:17 ` [PATCH v9 4/9] spi: cadence: Add Marvell SDMA operations Witold Sadowski
2024-06-24 14:29 ` Mark Brown
2024-06-28 13:45 ` [EXTERNAL] " Witold Sadowski
2024-06-28 13:52 ` Mark Brown
2024-06-19 14:17 ` [PATCH v9 5/9] spi: cadence: Add Marvell xSPI interrupt changes Witold Sadowski
2024-06-19 14:17 ` [PATCH v9 6/9] spi: cadence: Add Marvell xfer operation support Witold Sadowski
2024-06-24 15:29 ` Mark Brown
2024-06-28 13:48 ` [EXTERNAL] " Witold Sadowski
2024-06-28 13:57 ` Mark Brown
2024-06-19 14:17 ` [PATCH v9 7/9] spi: cadence: Change resource mapping Witold Sadowski
2024-06-19 14:17 ` Witold Sadowski [this message]
2024-06-19 14:17 ` [PATCH v9 9/9] spi: cadence: Try to read spi-tx/rx-bus width property using ACPI Witold Sadowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619141716.1785467-9-wsadowski@marvell.com \
--to=wsadowski@marvell.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pmalgujar@marvell.com \
--cc=pthombar@cadence.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).