linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/3] spi: add devm_spi_optimize_message() helper
Date: Mon, 24 Jun 2024 20:43:32 +0100	[thread overview]
Message-ID: <20240624204332.7cb1243a@jic23-huawei> (raw)
In-Reply-To: <20240624203918.3ee643db@jic23-huawei>

On Mon, 24 Jun 2024 20:39:18 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Sun, 23 Jun 2024 18:20:39 +0100
> Mark Brown <broonie@kernel.org> wrote:
> 
> > On Fri, Jun 21, 2024 at 03:51:29PM -0500, David Lechner wrote:  
> > > In the IIO subsystem, we are finding that it is common to call
> > > spi_optimize_message() during driver probe since the SPI message
> > > doesn't change for the lifetime of the driver. This patch adds a
> > > devm_spi_optimize_message() helper to simplify this common pattern.    
> > 
> > The following changes since commit 6ba59ff4227927d3a8530fc2973b80e94b54d58f:
> > 
> >   Linux 6.10-rc4 (2024-06-16 13:40:16 -0700)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-devm-optimize  
> 
> Thanks.  Applied patch 3 on a merge of that tag into the togreg branch
> of iio.git which I've pushed out as testing to see if anything went
> horribly wrong ;)
> 
Hit send too soon.  The new devm_spi_optmize_message() is missing an
EXPORT_SYMBOL_*  so my local build test with modules failed.

Jonathan

> Jonathan
> 
> > 
> > for you to fetch changes up to d4a0055fdc22381fa256e345095e88d134e354c5:
> > 
> >   spi: add devm_spi_optimize_message() helper (2024-06-22 12:14:33 +0100)
> > 
> > ----------------------------------------------------------------
> > spi: add devm_spi_optimize_message() helper
> > 
> > Helper from David Lechner <dlechner@baylibre.com>:
> > 
> >     In the IIO subsystem, we are finding that it is common to call
> >     spi_optimize_message() during driver probe since the SPI message
> >     doesn't change for the lifetime of the driver. This patch adds a
> >     devm_spi_optimize_message() helper to simplify this common pattern.
> > 
> > ----------------------------------------------------------------
> > David Lechner (2):
> >       Documentation: devres: add missing SPI helpers
> >       spi: add devm_spi_optimize_message() helper
> > 
> >  Documentation/driver-api/driver-model/devres.rst |  3 +++
> >  drivers/spi/spi.c                                | 27 ++++++++++++++++++++++++
> >  include/linux/spi/spi.h                          |  2 ++
> >  3 files changed, 32 insertions(+)  
> 


      reply	other threads:[~2024-06-24 19:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 20:51 [PATCH 0/3] spi: add devm_spi_optimize_message() helper David Lechner
2024-06-21 20:51 ` [PATCH 1/3] Documentation: devres: add missing SPI helpers David Lechner
2024-06-21 20:51 ` [PATCH 2/3] spi: add devm_spi_optimize_message() helper David Lechner
2024-06-24 19:44   ` Jonathan Cameron
2024-06-21 20:51 ` [PATCH 3/3] iio: adc: ad7944: use devm_spi_optimize_message() David Lechner
2024-06-23 10:15 ` [PATCH 0/3] spi: add devm_spi_optimize_message() helper Jonathan Cameron
2024-06-23 16:47 ` (subset) " Mark Brown
2024-06-23 17:20 ` Mark Brown
2024-06-24 19:39   ` Jonathan Cameron
2024-06-24 19:43     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624204332.7cb1243a@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dlechner@baylibre.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).