linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Kanak Shilledar <kanakshilledar@gmail.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: spi: snps,dw-apb-ssi.yaml: update compatible property
Date: Mon, 1 Jul 2024 15:10:40 +0100	[thread overview]
Message-ID: <20240701-unveiling-violation-b351a2514a3e@spud> (raw)
In-Reply-To: <20240701121355.262259-3-kanakshilledar@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

On Mon, Jul 01, 2024 at 05:43:52PM +0530, Kanak Shilledar wrote:

$subject: dt-bindings: spi: snps,dw-apb-ssi.yaml: update compatible property

Mark likes SPI bindings to be worked "spi: dt-bindings: ...", but
additionally I think the subject should say something like "add support
for T-Head th1520" or similar, what you've got is pretty generic.
Not requesting a respin for that alone, maybe Mark will grab it as-is.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> updated compatible property to include "thead,th1520-spi" for the
> TH1520 SoC SPI Controller.
> 
> Signed-off-by: Kanak Shilledar <kanakshilledar@gmail.com>
> ---
> Changes in v2:
> - Separated from a single patch file
> ---
>  Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index fde3776a558b..bccd00a1ddd0 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -88,6 +88,10 @@ properties:
>                - renesas,r9a06g032-spi # RZ/N1D
>                - renesas,r9a06g033-spi # RZ/N1S
>            - const: renesas,rzn1-spi   # RZ/N1
> +      - description: T-HEAD TH1520 SoC SPI Controller
> +        items:
> +          - const: thead,th1520-spi
> +          - const: snps,dw-apb-ssi
>  
>    reg:
>      minItems: 1
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-07-01 14:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 12:13 [PATCH v2 0/3] Add basic SPI support on TH1520 Kanak Shilledar
2024-07-01 12:13 ` [PATCH v2 1/3] dt-bindings: spi: snps,dw-apb-ssi.yaml: update compatible property Kanak Shilledar
2024-07-01 14:10   ` Conor Dooley [this message]
2024-07-01 12:13 ` [PATCH v2 2/3] spi: dw-mmio: update dw_spi_mmio_of_match struct with thead Kanak Shilledar
2024-07-01 13:17   ` Samuel Holland
2024-07-01 18:57     ` Serge Semin
2024-07-03  7:28       ` Conor Dooley
2024-07-03 13:12         ` Kanak Shilledar
2024-07-03 14:27           ` Conor Dooley
2024-07-03 14:37             ` Kanak Shilledar
2024-07-01 12:13 ` [PATCH v2 3/3] riscv: dts: thead: add basic spi node Kanak Shilledar
2024-07-03 14:45   ` Conor Dooley
2024-07-04  5:42     ` Kanak Shilledar
2024-07-04 16:49       ` Conor Dooley
2024-07-04 16:59     ` Drew Fustini
2024-07-04 17:53       ` Drew Fustini
2024-07-05  9:11         ` Kanak Shilledar
2024-07-01 18:55 ` (subset) [PATCH v2 0/3] Add basic SPI support on TH1520 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701-unveiling-violation-b351a2514a3e@spud \
    --to=conor@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=guoren@kernel.org \
    --cc=jszhang@kernel.org \
    --cc=kanakshilledar@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).