From: Nuno Sa <nuno.sa@analog.com>
To: <linux-spi@vger.kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>
Subject: [PATCH 3/4] spi: xcomm: remove i2c_set_clientdata()
Date: Thu, 4 Jul 2024 15:49:14 +0200 [thread overview]
Message-ID: <20240704-dev-spi-xcomm-gpiochip-v1-3-653db6fbef36@analog.com> (raw)
In-Reply-To: <20240704-dev-spi-xcomm-gpiochip-v1-0-653db6fbef36@analog.com>
i2c_get_clientdata() is not being called anywhere so that we do not need
to set clientdata.
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
---
drivers/spi/spi-xcomm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-xcomm.c b/drivers/spi/spi-xcomm.c
index 5a27eaed4183..136d81fb5f56 100644
--- a/drivers/spi/spi-xcomm.c
+++ b/drivers/spi/spi-xcomm.c
@@ -274,7 +274,6 @@ static int spi_xcomm_probe(struct i2c_client *i2c)
host->flags = SPI_CONTROLLER_HALF_DUPLEX;
host->transfer_one_message = spi_xcomm_transfer_one;
host->dev.of_node = i2c->dev.of_node;
- i2c_set_clientdata(i2c, host);
ret = devm_spi_register_controller(&i2c->dev, host);
if (ret < 0)
--
2.45.2
next prev parent reply other threads:[~2024-07-04 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 13:49 [PATCH 0/4] spi: xcomm: support GPO pin Nuno Sa
2024-07-04 13:49 ` [PATCH 1/4] spi: xcomm: add gpiochip support Nuno Sa
2024-07-04 13:53 ` Mark Brown
2024-07-04 14:00 ` Nuno Sá
2024-07-04 15:45 ` Mark Brown
2024-07-05 9:13 ` Nuno Sá
2024-07-04 13:49 ` [PATCH 2/4] spi: xcomm: make use of devm_spi_alloc_host() Nuno Sa
2024-07-04 13:49 ` Nuno Sa [this message]
2024-07-04 13:49 ` [PATCH 4/4] spi: xcomm: fix coding style Nuno Sa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704-dev-spi-xcomm-gpiochip-v1-3-653db6fbef36@analog.com \
--to=nuno.sa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).