From: Raju Rangoju <Raju.Rangoju@amd.com>
To: <broonie@kernel.org>, <linux-spi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <sanju.mehta@amd.com>,
<krishnamoorthi.m@amd.com>, <akshata.mukundshetty@amd.com>,
<Raju.Rangoju@amd.com>
Subject: [PATCH V2 3/8] spi: spi_amd: Replace ioread/iowrite calls
Date: Wed, 25 Sep 2024 19:06:39 +0530 [thread overview]
Message-ID: <20240925133644.2922359-4-Raju.Rangoju@amd.com> (raw)
In-Reply-To: <20240925133644.2922359-1-Raju.Rangoju@amd.com>
All `ioread*` and `iowrite*` functions are better suited for architecture
independent code to ensure portability across different architectures.
Since AMD SoCs support only the x86 architecture, replacing all `ioread*`
and `iowrite*` calls with `read*` and `write*` calls can reduce the
overhead of ensuring portability and increase the speed of I/O operations.
Co-developed-by: Krishnamoorthi M <krishnamoorthi.m@amd.com>
Signed-off-by: Krishnamoorthi M <krishnamoorthi.m@amd.com>
Co-developed-by: Akshata MukundShetty <akshata.mukundshetty@amd.com>
Signed-off-by: Akshata MukundShetty <akshata.mukundshetty@amd.com>
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
---
drivers/spi/spi-amd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c
index 17a8401216e4..1d1a18ee0bb5 100644
--- a/drivers/spi/spi-amd.c
+++ b/drivers/spi/spi-amd.c
@@ -114,12 +114,12 @@ struct amd_spi {
static inline u8 amd_spi_readreg8(struct amd_spi *amd_spi, int idx)
{
- return ioread8((u8 __iomem *)amd_spi->io_remap_addr + idx);
+ return readb((u8 __iomem *)amd_spi->io_remap_addr + idx);
}
static inline void amd_spi_writereg8(struct amd_spi *amd_spi, int idx, u8 val)
{
- iowrite8(val, ((u8 __iomem *)amd_spi->io_remap_addr + idx));
+ writeb(val, ((u8 __iomem *)amd_spi->io_remap_addr + idx));
}
static void amd_spi_setclear_reg8(struct amd_spi *amd_spi, int idx, u8 set, u8 clear)
@@ -132,12 +132,12 @@ static void amd_spi_setclear_reg8(struct amd_spi *amd_spi, int idx, u8 set, u8 c
static inline u32 amd_spi_readreg32(struct amd_spi *amd_spi, int idx)
{
- return ioread32((u8 __iomem *)amd_spi->io_remap_addr + idx);
+ return readl((u8 __iomem *)amd_spi->io_remap_addr + idx);
}
static inline void amd_spi_writereg32(struct amd_spi *amd_spi, int idx, u32 val)
{
- iowrite32(val, ((u8 __iomem *)amd_spi->io_remap_addr + idx));
+ writel(val, ((u8 __iomem *)amd_spi->io_remap_addr + idx));
}
static inline void amd_spi_setclear_reg32(struct amd_spi *amd_spi, int idx, u32 set, u32 clear)
--
2.34.1
next prev parent reply other threads:[~2024-09-25 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 13:36 [PATCH V2 0/8] spi: spi_amd: Performance Optimization Patch Series Raju Rangoju
2024-09-25 13:36 ` [PATCH V2 1/8] spi: spi_amd: Sort headers alphabetically Raju Rangoju
2024-09-25 13:36 ` [PATCH V2 2/8] spi: spi_amd: Enable dual and quad I/O modes Raju Rangoju
2024-09-25 13:36 ` Raju Rangoju [this message]
2024-09-25 13:36 ` [PATCH V2 4/8] spi: spi_amd: Updates to set tx/rx count functions Raju Rangoju
2024-09-25 13:36 ` [PATCH V2 5/8] spi: spi_amd: Optimize IO operations Raju Rangoju
2024-09-25 13:36 ` [PATCH V2 6/8] spi: spi_amd: Add support for HID2 SPI controller Raju Rangoju
2024-09-25 13:36 ` [PATCH V2 7/8] spi: spi_amd: Set controller address mode Raju Rangoju
2024-09-25 13:36 ` [PATCH V2 8/8] spi: spi_amd: Add HIDDMA basic read support Raju Rangoju
2024-09-30 23:51 ` [PATCH V2 0/8] spi: spi_amd: Performance Optimization Patch Series Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925133644.2922359-4-Raju.Rangoju@amd.com \
--to=raju.rangoju@amd.com \
--cc=akshata.mukundshetty@amd.com \
--cc=broonie@kernel.org \
--cc=krishnamoorthi.m@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sanju.mehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox