* [PATCH 2/3] spi: spidev: Add an entry for lwn,bk4-spi
2024-10-23 12:00 [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Fabio Estevam
@ 2024-10-23 12:00 ` Fabio Estevam
2024-10-23 12:00 ` [PATCH 3/3] ARM: dts: vf610-bk4: Use the more specific "lwn,bk4-spi" Fabio Estevam
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Fabio Estevam @ 2024-10-23 12:00 UTC (permalink / raw)
To: robh
Cc: krzk+dt, conor+dt, devicetree, broonie, linux-spi, shawnguo,
linux-arm-kernel, lukma, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Currently, the compatible string used for Liebherr's BK4 external SPI
controller device is "lwn,bk4", which is the same as the board compatible
string documented at fsl.yaml.
This causes several dt-schema warnings:
make dtbs_check DT_SCHEMA_FILES=fsl.yaml
...
['lwn,bk4'] is too short
'lwn,bk4' is not one of ['tq,imx8dxp-tqma8xdp-mba8xx']
'lwn,bk4' is not one of ['tq,imx8qxp-tqma8xqp-mba8xx']
'lwn,bk4' is not one of ['armadeus,imx1-apf9328', 'fsl,imx1ads']
...
Add a more specific "lwn,bk4-spi" compatible string entry for this
device to fix the problem.
The original "lwn,bk4" is kept to keep compatibility with old DTBs.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
drivers/spi/spidev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 653f82984216..2b87b9ae56c0 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -705,6 +705,7 @@ static const struct spi_device_id spidev_spi_ids[] = {
{ .name = "ltc2488" },
{ .name = "sx1301" },
{ .name = "bk4" },
+ { .name = "bk4-spi" },
{ .name = "dhcom-board" },
{ .name = "m53cpld" },
{ .name = "spi-petra" },
@@ -734,6 +735,7 @@ static const struct of_device_id spidev_dt_ids[] = {
{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
{ .compatible = "lineartechnology,ltc2488", .data = &spidev_of_check },
{ .compatible = "lwn,bk4", .data = &spidev_of_check },
+ { .compatible = "lwn,bk4-spi", .data = &spidev_of_check },
{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
{ .compatible = "micron,spi-authenta", .data = &spidev_of_check },
{ .compatible = "rohm,bh2228fv", .data = &spidev_of_check },
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/3] ARM: dts: vf610-bk4: Use the more specific "lwn,bk4-spi"
2024-10-23 12:00 [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Fabio Estevam
2024-10-23 12:00 ` [PATCH 2/3] spi: spidev: Add an entry for lwn,bk4-spi Fabio Estevam
@ 2024-10-23 12:00 ` Fabio Estevam
2024-10-23 15:17 ` [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Lukasz Majewski
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Fabio Estevam @ 2024-10-23 12:00 UTC (permalink / raw)
To: robh
Cc: krzk+dt, conor+dt, devicetree, broonie, linux-spi, shawnguo,
linux-arm-kernel, lukma, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Currently, the compatible string used for the spidev device is "lwn,bk4",
which is the same as the board compatible string documented at fsl.yaml.
This causes several dt-schema warnings:
make dtbs_check DT_SCHEMA_FILES=fsl.yaml
...
['lwn,bk4'] is too short
'lwn,bk4' is not one of ['tq,imx8dxp-tqma8xdp-mba8xx']
'lwn,bk4' is not one of ['tq,imx8qxp-tqma8xqp-mba8xx']
'lwn,bk4' is not one of ['armadeus,imx1-apf9328', 'fsl,imx1ads']
...
Use a more specific "lwn,bk4-spi" compatible string to fix the problem.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/boot/dts/nxp/vf/vf610-bk4.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/vf/vf610-bk4.dts b/arch/arm/boot/dts/nxp/vf/vf610-bk4.dts
index 722182f5fd17..2492fb99956c 100644
--- a/arch/arm/boot/dts/nxp/vf/vf610-bk4.dts
+++ b/arch/arm/boot/dts/nxp/vf/vf610-bk4.dts
@@ -119,7 +119,7 @@ &dspi0 {
status = "okay";
spidev0@0 {
- compatible = "lwn,bk4";
+ compatible = "lwn,bk4-spi";
spi-max-frequency = <30000000>;
reg = <0>;
fsl,spi-cs-sck-delay = <200>;
@@ -136,7 +136,7 @@ &dspi3 {
#address-cells = <0>;
slave {
- compatible = "lwn,bk4";
+ compatible = "lwn,bk4-spi";
spi-max-frequency = <30000000>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
2024-10-23 12:00 [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Fabio Estevam
2024-10-23 12:00 ` [PATCH 2/3] spi: spidev: Add an entry for lwn,bk4-spi Fabio Estevam
2024-10-23 12:00 ` [PATCH 3/3] ARM: dts: vf610-bk4: Use the more specific "lwn,bk4-spi" Fabio Estevam
@ 2024-10-23 15:17 ` Lukasz Majewski
2024-10-24 15:14 ` Rob Herring
2024-10-23 16:37 ` Conor Dooley
2024-12-02 16:51 ` (subset) " Mark Brown
4 siblings, 1 reply; 9+ messages in thread
From: Lukasz Majewski @ 2024-10-23 15:17 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh, krzk+dt, conor+dt, devicetree, broonie, linux-spi, shawnguo,
linux-arm-kernel, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 4106 bytes --]
Hi Fabio,
> From: Fabio Estevam <festevam@denx.de>
>
> Add a lwn,bk4-spi.yaml binding for Liebherr's BK4 external SPI
> controller.
>
> Currently, the compatible string used for this device is "lwn,bk4",
> which is the same as the board compatible string documented at
> fsl.yaml.
>
> This causes several dt-schema warnings:
>
> make dtbs_check DT_SCHEMA_FILES=fsl.yaml
> ...
>
> ['lwn,bk4'] is too short
> 'lwn,bk4' is not one of ['tq,imx8dxp-tqma8xdp-mba8xx']
> 'lwn,bk4' is not one of ['tq,imx8qxp-tqma8xqp-mba8xx']
> 'lwn,bk4' is not one of ['armadeus,imx1-apf9328', 'fsl,imx1ads']
> ...
>
> Use a more specific "lwn,bk4-spi" compatible string for this
> device.
>
Thanks for updating this.
BK4 is another example of to be long-time supported device... :-)
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> .../devicetree/bindings/misc/lwn,bk4-spi.yaml | 54
> +++++++++++++++++++ .../devicetree/bindings/misc/lwn-bk4.txt |
> 26 --------- 2 files changed, 54 insertions(+), 26 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml delete mode
> 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml
> b/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml new file
> mode 100644 index 000000000000..7fb86e6abade
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/lwn,bk4-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Liebherr's BK4 external SPI controller
> +
> +maintainers:
> + - Lukasz Majewski <lukma@denx.de>
> +
> +description: |
> + Liebherr's BK4 external SPI controller is a device which handles
> data
> + acquisition from compatible industrial peripherals.
> + The SPI is used for data and management purposes in both master and
> + slave modes.
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: lwn,bk4-spi
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 30000000
> +
> + fsl,spi-cs-sck-delay: true
> +
> + fsl,spi-sck-cs-delay: true
> +
> +required:
> + - compatible
> + - spi-max-frequency
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + spidev@0 {
> + compatible = "lwn,bk4-spi";
> + reg = <0>;
> + spi-max-frequency = <30000000>;
> + fsl,spi-cs-sck-delay = <200>;
> + fsl,spi-sck-cs-delay = <400>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> b/Documentation/devicetree/bindings/misc/lwn-bk4.txt deleted file
> mode 100644 index d6a8c188c087..000000000000
> --- a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -* Liebherr's BK4 controller external SPI
> -
> -A device which handles data acquisition from compatible industrial
> -peripherals.
> -The SPI is used for data and management purposes in both master and
> -slave modes.
> -
> -Required properties:
> -
> -- compatible : Should be "lwn,bk4"
> -
> -Required SPI properties:
> -
> -- reg : Should be address of the device chip select within
> - the controller.
> -
> -- spi-max-frequency : Maximum SPI clocking speed of device in Hz,
> should be
> - 30MHz at most for the Liebherr's BK4 external bus.
> -
> -Example:
> -
> -spidev0: spi@0 {
> - compatible = "lwn,bk4";
> - spi-max-frequency = <30000000>;
> - reg = <0>;
> -};
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
2024-10-23 15:17 ` [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Lukasz Majewski
@ 2024-10-24 15:14 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2024-10-24 15:14 UTC (permalink / raw)
To: Lukasz Majewski
Cc: Fabio Estevam, krzk+dt, conor+dt, devicetree, broonie, linux-spi,
shawnguo, linux-arm-kernel, Fabio Estevam
On Wed, Oct 23, 2024 at 05:17:39PM +0200, Lukasz Majewski wrote:
> Hi Fabio,
>
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Add a lwn,bk4-spi.yaml binding for Liebherr's BK4 external SPI
> > controller.
> >
> > Currently, the compatible string used for this device is "lwn,bk4",
> > which is the same as the board compatible string documented at
> > fsl.yaml.
> >
> > This causes several dt-schema warnings:
> >
> > make dtbs_check DT_SCHEMA_FILES=fsl.yaml
> > ...
> >
> > ['lwn,bk4'] is too short
> > 'lwn,bk4' is not one of ['tq,imx8dxp-tqma8xdp-mba8xx']
> > 'lwn,bk4' is not one of ['tq,imx8qxp-tqma8xqp-mba8xx']
> > 'lwn,bk4' is not one of ['armadeus,imx1-apf9328', 'fsl,imx1ads']
> > ...
> >
> > Use a more specific "lwn,bk4-spi" compatible string for this
> > device.
> >
>
> Thanks for updating this.
>
> BK4 is another example of to be long-time supported device... :-)
Does that mean we shouldn't be changing this compatible?
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
2024-10-23 12:00 [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Fabio Estevam
` (2 preceding siblings ...)
2024-10-23 15:17 ` [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Lukasz Majewski
@ 2024-10-23 16:37 ` Conor Dooley
2024-10-23 17:33 ` Mark Brown
2024-12-02 16:51 ` (subset) " Mark Brown
4 siblings, 1 reply; 9+ messages in thread
From: Conor Dooley @ 2024-10-23 16:37 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh, krzk+dt, conor+dt, devicetree, broonie, linux-spi, shawnguo,
linux-arm-kernel, lukma, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 4187 bytes --]
On Wed, Oct 23, 2024 at 09:00:13AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Add a lwn,bk4-spi.yaml binding for Liebherr's BK4 external SPI controller.
>
> Currently, the compatible string used for this device is "lwn,bk4",
> which is the same as the board compatible string documented at fsl.yaml.
>
> This causes several dt-schema warnings:
>
> make dtbs_check DT_SCHEMA_FILES=fsl.yaml
> ...
>
> ['lwn,bk4'] is too short
> 'lwn,bk4' is not one of ['tq,imx8dxp-tqma8xdp-mba8xx']
> 'lwn,bk4' is not one of ['tq,imx8qxp-tqma8xqp-mba8xx']
> 'lwn,bk4' is not one of ['armadeus,imx1-apf9328', 'fsl,imx1ads']
> ...
>
> Use a more specific "lwn,bk4-spi" compatible string for this
> device.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> .../devicetree/bindings/misc/lwn,bk4-spi.yaml | 54 +++++++++++++++++++
> .../devicetree/bindings/misc/lwn-bk4.txt | 26 ---------
> 2 files changed, 54 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml
> delete mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml b/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml
> new file mode 100644
> index 000000000000..7fb86e6abade
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/lwn,bk4-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Liebherr's BK4 external SPI controller
> +
> +maintainers:
> + - Lukasz Majewski <lukma@denx.de>
> +
> +description: |
> + Liebherr's BK4 external SPI controller is a device which handles data
> + acquisition from compatible industrial peripherals.
> + The SPI is used for data and management purposes in both master and
> + slave modes.
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: lwn,bk4-spi
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 30000000
> +
> + fsl,spi-cs-sck-delay: true
> +
> + fsl,spi-sck-cs-delay: true
Why does this have fsl properties? I figure they're taken from the dts,
but spidev doesn't use them, right?
> +
> +required:
> + - compatible
> + - spi-max-frequency
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + spidev@0 {
^^^^^^
This should really be the type of device that this is. The way you word
the description etc doesn't really make much sense to me but it sounds
like this is a daisy chained spi controller? Or is it a data acquisition
device that is a spi "slave"?
> + compatible = "lwn,bk4-spi";
> + reg = <0>;
> + spi-max-frequency = <30000000>;
> + fsl,spi-cs-sck-delay = <200>;
> + fsl,spi-sck-cs-delay = <400>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> deleted file mode 100644
> index d6a8c188c087..000000000000
> --- a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -* Liebherr's BK4 controller external SPI
> -
> -A device which handles data acquisition from compatible industrial
> -peripherals.
> -The SPI is used for data and management purposes in both master and
> -slave modes.
> -
> -Required properties:
> -
> -- compatible : Should be "lwn,bk4"
> -
> -Required SPI properties:
> -
> -- reg : Should be address of the device chip select within
> - the controller.
> -
> -- spi-max-frequency : Maximum SPI clocking speed of device in Hz, should be
> - 30MHz at most for the Liebherr's BK4 external bus.
> -
> -Example:
> -
> -spidev0: spi@0 {
> - compatible = "lwn,bk4";
> - spi-max-frequency = <30000000>;
> - reg = <0>;
> -};
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
2024-10-23 16:37 ` Conor Dooley
@ 2024-10-23 17:33 ` Mark Brown
2024-10-23 18:06 ` Conor Dooley
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2024-10-23 17:33 UTC (permalink / raw)
To: Conor Dooley
Cc: Fabio Estevam, robh, krzk+dt, conor+dt, devicetree, linux-spi,
shawnguo, linux-arm-kernel, lukma, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
On Wed, Oct 23, 2024 at 05:37:29PM +0100, Conor Dooley wrote:
> On Wed, Oct 23, 2024 at 09:00:13AM -0300, Fabio Estevam wrote:
> > + fsl,spi-cs-sck-delay: true
> > + fsl,spi-sck-cs-delay: true
> Why does this have fsl properties? I figure they're taken from the dts,
> but spidev doesn't use them, right?
These are controlling signal timing and implemented by the SPI
controller rather than the device - they're the timing the device
requires.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
2024-10-23 17:33 ` Mark Brown
@ 2024-10-23 18:06 ` Conor Dooley
0 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2024-10-23 18:06 UTC (permalink / raw)
To: Mark Brown
Cc: Fabio Estevam, robh, krzk+dt, conor+dt, devicetree, linux-spi,
shawnguo, linux-arm-kernel, lukma, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Wed, Oct 23, 2024 at 06:33:07PM +0100, Mark Brown wrote:
> On Wed, Oct 23, 2024 at 05:37:29PM +0100, Conor Dooley wrote:
> > On Wed, Oct 23, 2024 at 09:00:13AM -0300, Fabio Estevam wrote:
>
> > > + fsl,spi-cs-sck-delay: true
>
> > > + fsl,spi-sck-cs-delay: true
>
> > Why does this have fsl properties? I figure they're taken from the dts,
> > but spidev doesn't use them, right?
>
> These are controlling signal timing and implemented by the SPI
> controller rather than the device - they're the timing the device
> requires.
I see, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
2024-10-23 12:00 [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Fabio Estevam
` (3 preceding siblings ...)
2024-10-23 16:37 ` Conor Dooley
@ 2024-12-02 16:51 ` Mark Brown
4 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2024-12-02 16:51 UTC (permalink / raw)
To: robh, Fabio Estevam
Cc: krzk+dt, conor+dt, devicetree, linux-spi, shawnguo,
linux-arm-kernel, lukma, Fabio Estevam
On Wed, 23 Oct 2024 09:00:13 -0300, Fabio Estevam wrote:
> Add a lwn,bk4-spi.yaml binding for Liebherr's BK4 external SPI controller.
>
> Currently, the compatible string used for this device is "lwn,bk4",
> which is the same as the board compatible string documented at fsl.yaml.
>
> This causes several dt-schema warnings:
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
commit: 36e7886075262429158aec6f258e6a5a92f025b1
[2/3] spi: spidev: Add an entry for lwn,bk4-spi
commit: 096c34ddf5835f02f5260719cd8a16fcf5e5e56f
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 9+ messages in thread