From: Greg KH <gregkh@linuxfoundation.org>
To: Lars Pedersen <lapeddk@gmail.com>
Cc: stable@vger.kernel.org, regressions@lists.linux.dev,
broonie@kernel.org, linux-spi@vger.kernel.org,
psiddaiah@mvista.com
Subject: Re: SPI regression seen on ARM am335x in kernel 6.12.8 and 6.6.71
Date: Fri, 17 Jan 2025 13:32:21 +0100 [thread overview]
Message-ID: <2025011703-erupt-oblivion-82a0@gregkh> (raw)
In-Reply-To: <CAKd8=GsoKj5eG6VAMkrxMbzNyoBX=JiwafrfXman8xMNK+XU_w@mail.gmail.com>
On Thu, Jan 16, 2025 at 03:21:13PM +0100, Lars Pedersen wrote:
> Hi. We have discovered an SPI regression when upgrading from 6.1.99 to
> a newer LTS version. Same error on kernel 6.6.71 and 6.12.8.
>
> I think we have identified the problem down to the reference clock
> calculation that seems to end up to zero in the spi-omap2-mcspi
> driver.
>
> Also we think it relates to commit
> 4c6ac5446d060f0bf435ccc8bc3aa7b7b5f718ad, where OMAP2_MCSPI_MAX_FREQ
> is used as fallback on error. In our case it seems to hit the else
> case.
>
> Snippets for device tree, spi-omap2-mcspi driver and kernel divide by
> zero error log with dynamic debug enabled.
If you revert the offending commit, does that solve the issue?
thanks,
greg k-h
next prev parent reply other threads:[~2025-01-17 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 14:21 SPI regression seen on ARM am335x in kernel 6.12.8 and 6.6.71 Lars Pedersen
2025-01-17 12:32 ` Greg KH [this message]
2025-01-17 14:49 ` Lars Pedersen
2025-01-23 5:46 ` Sicelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025011703-erupt-oblivion-82a0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=lapeddk@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=psiddaiah@mvista.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).