From: Kevin Hao <haokexin@gmail.com>
To: linux-spi@vger.kernel.org
Cc: Han Xu <han.xu@nxp.com>, Mark Brown <broonie@kernel.org>,
imx@lists.linux.dev
Subject: [PATCH 2/3] spi: fsl-spi: Remove redundant probe error message
Date: Thu, 10 Apr 2025 14:56:10 +0800 [thread overview]
Message-ID: <20250410-spi-v1-2-56e867cc19cf@gmail.com> (raw)
In-Reply-To: <20250410-spi-v1-0-56e867cc19cf@gmail.com>
An error message is already emitted by the driver core function
call_driver_probe() when the driver probe fails. Therefore, this
redundant probe error message is removed.
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
drivers/spi/spi-fsl-qspi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
index 2f54dc09d11b1c56cfe57ceec8452fbb29322d3f..b5ecffcaf7955e2ec9bb3e2857f8bc14d73a2f90 100644
--- a/drivers/spi/spi-fsl-qspi.c
+++ b/drivers/spi/spi-fsl-qspi.c
@@ -963,7 +963,6 @@ static int fsl_qspi_probe(struct platform_device *pdev)
err_put_ctrl:
spi_controller_put(ctlr);
- dev_err(dev, "Freescale QuadSPI probe failed\n");
return ret;
}
--
2.49.0
next prev parent reply other threads:[~2025-04-10 6:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 6:56 [PATCH 0/3] spi: fsl-qspi: Fix double cleanup in probe error path Kevin Hao
2025-04-10 6:56 ` [PATCH 1/3] " Kevin Hao
2025-04-10 15:45 ` Frank Li
2025-04-10 15:52 ` Frank Li
2025-04-10 6:56 ` Kevin Hao [this message]
2025-04-10 6:56 ` [PATCH 3/3] spi: fsl-qspi: Simplify probe error handling using managed API Kevin Hao
2025-04-10 15:00 ` [PATCH 0/3] spi: fsl-qspi: Fix double cleanup in probe error path Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410-spi-v1-2-56e867cc19cf@gmail.com \
--to=haokexin@gmail.com \
--cc=broonie@kernel.org \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox