From: Haibo Chen <haibo.chen@nxp.com>
To: Haibo Chen <haibo.chen@nxp.com>, Han Xu <han.xu@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/5] spi: spi-nxp-fspi: use guard(mutex) to simplify the code
Date: Mon, 28 Apr 2025 18:06:45 +0800 [thread overview]
Message-ID: <20250428-flexspipatch-v3-3-61d5e8f591bc@nxp.com> (raw)
In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com>
Use guard(mutex) to simplify the code logic.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/spi/spi-nxp-fspi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index f7c3330a19009223cbffae8673d264246418e561..ca0b51a254c15f45a9e91907900d94d77f1d5dff 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -932,11 +932,10 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
struct nxp_fspi *f = spi_controller_get_devdata(mem->spi->controller);
int err = 0;
- mutex_lock(&f->lock);
+ guard(mutex)(&f->lock);
err = pm_runtime_get_sync(f->dev);
if (err < 0) {
- mutex_unlock(&f->lock);
dev_err(f->dev, "Failed to enable clock %d\n", __LINE__);
return err;
}
@@ -972,7 +971,6 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
pm_runtime_mark_last_busy(f->dev);
pm_runtime_put_autosuspend(f->dev);
- mutex_unlock(&f->lock);
return err;
}
--
2.34.1
next prev parent reply other threads:[~2025-04-28 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:06 [PATCH v3 0/5] This patch set did some clean up and add runtime pm support for flexspi driver Haibo Chen
2025-04-28 10:06 ` [PATCH v3 1/5] spi: spi-nxp-fspi: remove the goto in probe Haibo Chen
2025-04-28 10:06 ` [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi Haibo Chen
2025-04-30 19:30 ` ALOK TIWARI
2025-05-01 20:47 ` Mark Brown
2025-05-06 6:19 ` Bough Chen
2025-04-28 10:06 ` Haibo Chen [this message]
2025-04-28 10:06 ` [PATCH v3 4/5] spi: spi-nxp-fspi: remove the unchecked return value for nxp_fspi_clk_disable_unprep Haibo Chen
2025-04-28 10:06 ` [PATCH v3 5/5] spi: nxp-fspi: use devm instead of remove for driver detach Haibo Chen
2025-05-07 2:57 ` [PATCH v3 0/5] This patch set did some clean up and add runtime pm support for flexspi driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428-flexspipatch-v3-3-61d5e8f591bc@nxp.com \
--to=haibo.chen@nxp.com \
--cc=broonie@kernel.org \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).