From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Thangaraj Samynathan <thangaraj.s@microchip.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [broonie-spi:for-next 9/11] drivers/spi/spi-pci1xxxx.c:768 pci1xxxx_spi_probe() warn: missing error code? 'ret'
Date: Wed, 28 May 2025 10:43:32 +0300 [thread overview]
Message-ID: <202505281417.WyCoNJlC-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
head: 6aae49917bd543677e539df17556071edd9a273a
commit: b4608e944177531334a79f3df2cd14275b47808c [9/11] spi: spi-pci1xxxx: Fix Probe failure with Dual SPI instance with INTx interrupts
config: riscv-randconfig-r073-20250528 (https://download.01.org/0day-ci/archive/20250528/202505281417.WyCoNJlC-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202505281417.WyCoNJlC-lkp@intel.com/
smatch warnings:
drivers/spi/spi-pci1xxxx.c:768 pci1xxxx_spi_probe() warn: missing error code? 'ret'
vim +/ret +768 drivers/spi/spi-pci1xxxx.c
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 748 spi_sub_ptr->parent = spi_bus;
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 749 spi_sub_ptr->spi_xfer_in_progress = false;
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 750
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 751 if (!iter) {
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 752 ret = pcim_enable_device(pdev);
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 753 if (ret)
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 754 return -ENOMEM;
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 755
d981e7b3f25fbab Philipp Stanner 2025-04-17 756 ret = pcim_request_all_regions(pdev, DRV_NAME);
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 757 if (ret)
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 758 return -ENOMEM;
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 759
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 760 spi_bus->reg_base = pcim_iomap(pdev, 0, pci_resource_len(pdev, 0));
d981e7b3f25fbab Philipp Stanner 2025-04-17 761 if (!spi_bus->reg_base)
d981e7b3f25fbab Philipp Stanner 2025-04-17 762 return -EINVAL;
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 763
b4608e944177531 Thangaraj Samynathan 2025-05-27 764 num_vector = pci_alloc_irq_vectors(pdev, 1, hw_inst_cnt,
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 765 PCI_IRQ_ALL_TYPES);
b4608e944177531 Thangaraj Samynathan 2025-05-27 766 if (num_vector < 0) {
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 767 dev_err(&pdev->dev, "Error allocating MSI vectors\n");
d981e7b3f25fbab Philipp Stanner 2025-04-17 @768 return ret;
return num_vector;
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 769 }
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 770
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 771 init_completion(&spi_sub_ptr->spi_xfer_done);
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 772 /* Initialize Interrupts - SPI_INT */
1cc0cbea7167af5 Tharun Kumar P 2022-10-06 773 regval = readl(spi_bus->reg_base +
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-05-28 7:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505281417.WyCoNJlC-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=thangaraj.s@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox