From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk>,
Will Deacon <will@kernel.org>, Han Xu <han.xu@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>, Andrew Davis <afd@ti.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-leds@vger.kernel.org,
"Thomas Weißschuh" <linux@weissschuh.net>
Subject: [PATCH v6 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init()
Date: Mon, 09 Jun 2025 22:38:37 +0200 [thread overview]
Message-ID: <20250609-must_check-devm_mutex_init-v6-1-9540d5df9704@weissschuh.net> (raw)
In-Reply-To: <20250609-must_check-devm_mutex_init-v6-0-9540d5df9704@weissschuh.net>
Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something.
Add the missed check.
Fixes: 48900813abd2 ("spi: spi-nxp-fspi: remove the goto in probe")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/spi/spi-nxp-fspi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index e63c77e418231cd0698ffb73eeeebfbe63cc3065..f3d5765054132cd18b7257439ece971f58e9ceb2 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1273,7 +1273,9 @@ static int nxp_fspi_probe(struct platform_device *pdev)
if (ret)
return dev_err_probe(dev, ret, "Failed to request irq\n");
- devm_mutex_init(dev, &f->lock);
+ ret = devm_mutex_init(dev, &f->lock);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to initialize lock\n");
ctlr->bus_num = -1;
ctlr->num_chipselect = NXP_FSPI_MAX_CHIPSELECT;
--
2.49.0
next prev parent reply other threads:[~2025-06-09 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 20:38 [PATCH v6 0/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-06-09 20:38 ` Thomas Weißschuh [this message]
2025-06-09 20:59 ` [PATCH v6 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init() Mark Brown
2025-06-10 9:57 ` Andy Shevchenko
2025-06-10 11:46 ` Mark Brown
2025-06-11 8:33 ` Andy Shevchenko
2025-06-09 20:38 ` [PATCH v6 2/3] leds: lp8860: Check " Thomas Weißschuh
2025-06-09 21:11 ` Andrew Davis
2025-06-09 20:38 ` [PATCH v6 3/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609-must_check-devm_mutex_init-v6-1-9540d5df9704@weissschuh.net \
--to=linux@weissschuh.net \
--cc=afd@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=boqun.feng@gmail.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=vicentiu.galanopulo@remote-tech.co.uk \
--cc=will@kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).