linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: James Clark <james.clark@linaro.org>
Cc: hch@lst.de, olteanv@gmail.com, broonie@kernel.org,
	oe-kbuild-all@lists.linux.dev, arnd@arndb.de,
	larisa.grigore@nxp.com, Frank.li@nxp.com,
	linux-spi@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	iommu@lists.linux.dev
Subject: Re: [PATCH] dma-mapping: Stub out dma_{alloc,free,map}_pages() API
Date: Mon, 16 Jun 2025 13:29:27 +0200	[thread overview]
Message-ID: <20250616112927.GA21689@lst.de> (raw)
In-Reply-To: <20250616111749.316413-1-james.clark@linaro.org>

On Mon, Jun 16, 2025 at 12:17:49PM +0100, James Clark wrote:
> The implementations are in mapping.c which requires HAS_DMA so stub them
> out if not present. This is required for some drivers to pass randconfig
> builds.

No.  Just add the proper IS_ENABLED checks in the callers.  While these
kinds of stubs used to be popular they are really nasty in that the
calls unexpectedly just fail without the right depends.


  parent reply	other threads:[~2025-06-16 11:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13  9:28 [PATCH v2 0/5] spi: spi-fsl-dspi: Target mode improvements James Clark
2025-06-13  9:28 ` [PATCH v2 1/5] spi: spi-fsl-dspi: Clear completion counter before initiating transfer James Clark
2025-06-13  9:28 ` [PATCH v2 2/5] spi: spi-fsl-dspi: Use non-coherent memory for DMA James Clark
2025-06-15 16:31   ` kernel test robot
2025-06-16 11:17     ` [PATCH] dma-mapping: Stub out dma_{alloc,free,map}_pages() API James Clark
2025-06-16 11:21       ` James Clark
2025-06-16 11:28       ` Arnd Bergmann
2025-06-16 11:29       ` Christoph Hellwig [this message]
2025-06-16 12:06         ` Mark Brown
2025-06-16 12:08           ` Christoph Hellwig
2025-06-16 12:11             ` Mark Brown
2025-06-16 12:14               ` Christoph Hellwig
2025-06-16 13:05                 ` Mark Brown
2025-06-16 13:12                   ` Christoph Hellwig
2025-06-16 13:10                 ` James Clark
2025-06-16 13:13                   ` Christoph Hellwig
2025-06-16 13:14                     ` James Clark
2025-06-16 13:15                       ` James Clark
2025-06-16 13:19                         ` Christoph Hellwig
2025-06-16 13:23                           ` James Clark
2025-06-16 13:48                             ` Arnd Bergmann
2025-06-16 18:33                               ` Arnd Bergmann
2025-06-17  4:48                               ` Christoph Hellwig
2025-06-17  7:53                                 ` Arnd Bergmann
2025-06-17  8:26                                   ` Arnd Bergmann
2025-06-17 15:55                                     ` Jason Gunthorpe
2025-06-16 11:56   ` [PATCH v2 2/5] spi: spi-fsl-dspi: Use non-coherent memory for DMA Robin Murphy
2025-06-16 13:06     ` James Clark
2025-06-13  9:28 ` [PATCH v2 3/5] spi: spi-fsl-dspi: Increase DMA buffer size James Clark
2025-06-13  9:28 ` [PATCH v2 4/5] spi: spi-fsl-dspi: Store status directly in cur_msg->status James Clark
2025-06-13  9:29 ` [PATCH v2 5/5] spi: spi-fsl-dspi: Report FIFO overflows as errors James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616112927.GA21689@lst.de \
    --to=hch@lst.de \
    --cc=Frank.li@nxp.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=iommu@lists.linux.dev \
    --cc=james.clark@linaro.org \
    --cc=larisa.grigore@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=m.szyprowski@samsung.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=olteanv@gmail.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).