From: Rosen Penev <rosenp@gmail.com>
To: linux-spi@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
j4g8y7@gmail.com, linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv2 1/3] spi: rb4xx: depend on OF
Date: Tue, 26 Aug 2025 14:24:11 -0700 [thread overview]
Message-ID: <20250826212413.15065-2-rosenp@gmail.com> (raw)
In-Reply-To: <20250826212413.15065-1-rosenp@gmail.com>
There's no support for non OF platforms. Better to depend on OF
explicitly.
Also fixes a warning/error about the dt table being unused because of
of_match_ptr on non OF platforms.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/spi/Kconfig | 1 +
drivers/spi/spi-rb4xx.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 891729c9c564..cdeaa8e711fd 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -917,6 +917,7 @@ config SPI_ROCKCHIP_SFC
config SPI_RB4XX
tristate "Mikrotik RB4XX SPI master"
depends on SPI_MASTER && ATH79
+ depends on OF
help
SPI controller driver for the Mikrotik RB4xx series boards.
diff --git a/drivers/spi/spi-rb4xx.c b/drivers/spi/spi-rb4xx.c
index e71d3805b150..a795e263299e 100644
--- a/drivers/spi/spi-rb4xx.c
+++ b/drivers/spi/spi-rb4xx.c
@@ -199,7 +199,7 @@ static struct platform_driver rb4xx_spi_drv = {
.remove = rb4xx_spi_remove,
.driver = {
.name = "rb4xx-spi",
- .of_match_table = of_match_ptr(rb4xx_spi_dt_match),
+ .of_match_table = rb4xx_spi_dt_match,
},
};
--
2.50.1
next prev parent reply other threads:[~2025-08-26 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 21:24 [PATCHv2 0/3] add COMPILE_TEST support Rosen Penev
2025-08-26 21:24 ` Rosen Penev [this message]
2025-08-26 21:24 ` [PATCHv2 2/3] spi: rb4xx: " Rosen Penev
2025-08-26 21:24 ` [PATCHv2 3/3] spi: rb4xx: use devm for clk_prepare_enable Rosen Penev
2025-08-28 21:00 ` [PATCHv2 0/3] add COMPILE_TEST support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826212413.15065-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=broonie@kernel.org \
--cc=j4g8y7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).