Re: [PATCH v2 2/8] dt-bindings: iio: adc: adi,ad4030: Reference spi-peripheral-props

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]

On Thu, Sep 18, 2025 at 02:39:01PM -0500, David Lechner wrote:
> On 9/18/25 12:38 PM, Marcelo Schmitt wrote:
> > AD4030 and similar devices all connect to the system as SPI peripherals.
> > Reference spi-peripheral-props so common SPI peripheral can be used from
> > ad4030 dt-binding.
> > 
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml
> > index 54e7349317b7..a8fee4062d0e 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml
> > @@ -20,6 +20,8 @@ description: |
> >    * https://www.analog.com/media/en/technical-documentation/data-sheets/ad4630-24_ad4632-24.pdf
> >    * https://www.analog.com/media/en/technical-documentation/data-sheets/ad4630-16-4632-16.pdf
> >  
> > +$ref: /schemas/spi/spi-peripheral-props.yaml#
> 
> I think this is already referenced for all child nodes of a SPI
> controller because of pattern matching of:
> 
> patternProperties:
>   "^.*@[0-9a-f]+$":
>     type: object
>     $ref: spi-peripheral-props.yaml
> 
> in Documentation/devicetree/bindings/spi/spi-controller.yaml
> 
> So perhaps not strictly necessary?
> 
> Would be curious to know if there is some difference.

I think it's good form if you're actually referencing the properties. I
don't know if it actually makes a difference in the end result of
dtbs_check but it may in terms of making sure properties in this binding
are properly typed when it is tested against. In this case, it appears
you're only looking at uint32 properties so it mightn't have any impact.
Rob would know for sure.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]