From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
Ray Liu <ray.liu@airoha.com>, Mark Brown <broonie@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andy Shevchenko <andy@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org
Cc: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Andreas Gnau <andreas.gnau@iopsys.eu>,
Frieder Schrempf <frieder.schrempf@kontron.de>
Subject: [PATCH v7 01/17] spi: airoha: return an error for continuous mode dirmap creation cases
Date: Fri, 10 Oct 2025 06:31:20 +0300 [thread overview]
Message-ID: <20251010033136.1475673-2-mikhail.kshevetskiy@iopsys.eu> (raw)
In-Reply-To: <20251010033136.1475673-1-mikhail.kshevetskiy@iopsys.eu>
This driver can accelerate single page operations only, thus
continuous reading mode should not be used.
Continuous reading will use sizes up to the size of one erase block.
This size is much larger than the size of single flash page. Use this
difference to identify continuous reading and return an error.
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/spi/spi-airoha-snfi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c
index dbe640986825..043a03cd90a1 100644
--- a/drivers/spi/spi-airoha-snfi.c
+++ b/drivers/spi/spi-airoha-snfi.c
@@ -618,6 +618,10 @@ static int airoha_snand_dirmap_create(struct spi_mem_dirmap_desc *desc)
if (desc->info.offset + desc->info.length > U32_MAX)
return -EINVAL;
+ /* continuous reading is not supported */
+ if (desc->info.length > SPI_NAND_CACHE_SIZE)
+ return -E2BIG;
+
if (!airoha_snand_supports_op(desc->mem, &desc->info.op_tmpl))
return -EOPNOTSUPP;
--
2.51.0
next prev parent reply other threads:[~2025-10-10 3:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 3:31 [PATCH v7 00/17] spi: airoha: driver fixes & improvements Mikhail Kshevetskiy
2025-10-10 3:31 ` Mikhail Kshevetskiy [this message]
2025-10-10 3:31 ` [PATCH v7 02/17] spi: airoha: remove unnecessary restriction length Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 03/17] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 04/17] spi: airoha: remove unnecessary switch to non-dma mode Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 05/17] spi: airoha: switch back to non-dma mode in the case of error Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 06/17] spi: airoha: fix reading/writing of flashes with more than one plane per lun Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 07/17] spi: airoha: unify dirmap read/write code Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 08/17] spi: airoha: support of dualio/quadio flash reading commands Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 09/17] spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 10/17] spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 11/17] spi: airoha: set custom sector size equal to flash page size Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 12/17] spi: airoha: avoid reading flash page settings from SNFI registers during driver startup Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 13/17] spi: airoha: buffer must be 0xff-ed before writing Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 14/17] spi: airoha-snfi: make compatible with EN7523 SoC Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 15/17] spi: airoha-snfi: en7523: workaround flash damaging if UART_TXD was short to GND Mikhail Kshevetskiy
2025-10-10 3:31 ` [PATCH v7 16/17] dt-bindings: spi: airoha: add compatible for EN7523 Mikhail Kshevetskiy
2025-10-10 14:24 ` Conor Dooley
2025-10-10 14:57 ` Mikhail Kshevetskiy
2025-10-10 18:59 ` Rob Herring
2025-10-10 19:20 ` [PATCH v8 00/15] spi: airoha: driver fixes & improvements Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 01/15] spi: airoha: return an error for continuous mode dirmap creation cases Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 02/15] spi: airoha: remove unnecessary restriction length Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 03/15] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 04/15] spi: airoha: remove unnecessary switch to non-dma mode Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 05/15] spi: airoha: switch back to non-dma mode in the case of error Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 06/15] spi: airoha: fix reading/writing of flashes with more than one plane per lun Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 07/15] spi: airoha: unify dirmap read/write code Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 08/15] spi: airoha: support of dualio/quadio flash reading commands Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 09/15] spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 10/15] spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 11/15] spi: airoha: set custom sector size equal to flash page size Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 12/15] spi: airoha: avoid reading flash page settings from SNFI registers during driver startup Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 13/15] spi: airoha: buffer must be 0xff-ed before writing Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 14/15] spi: airoha-snfi: en7523: workaround flash damaging if UART_TXD was short to GND Mikhail Kshevetskiy
2025-10-10 19:20 ` [PATCH v8 15/15] arm: dts: airoha: en7523: add SNAND node Mikhail Kshevetskiy
2025-10-10 23:37 ` Krzysztof Kozlowski
2025-10-10 23:41 ` Krzysztof Kozlowski
2025-10-10 23:36 ` [PATCH v8 00/15] spi: airoha: driver fixes & improvements Krzysztof Kozlowski
2025-10-10 3:31 ` [PATCH v7 17/17] arm: dts: airoha: en7523: add SNAND node Mikhail Kshevetskiy
2025-10-10 19:32 ` [PATCH v7 00/17] spi: airoha: driver fixes & improvements Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010033136.1475673-2-mikhail.kshevetskiy@iopsys.eu \
--to=mikhail.kshevetskiy@iopsys.eu \
--cc=andreas.gnau@iopsys.eu \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ray.liu@airoha.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).