linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Jun Guo <jun.guo@cixtech.com>
Cc: peter.chen@cixtech.com, fugang.duan@cixtech.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, broonie@kernel.org,
	linux-spi@vger.kernel.org, michal.simek@amd.com,
	cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: spi: spi-cadence: update DT binding docs to support cix sky1 SoC
Date: Mon, 27 Oct 2025 16:51:41 +0000	[thread overview]
Message-ID: <20251027-strangely-reverence-6f47d87efca5@spud> (raw)
In-Reply-To: <20251027084239.2610141-3-jun.guo@cixtech.com>

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

On Mon, Oct 27, 2025 at 04:42:38PM +0800, Jun Guo wrote:
> - Add new compatible strings to the DT binding documents to support
>  cix sky1 SoC;
> - Adjust the configuration of the compatible property to support both
>  single-item and two-items cases.​​
> 
> Signed-off-by: Jun Guo <jun.guo@cixtech.com>
> ---
>  .../devicetree/bindings/spi/spi-cadence.yaml          | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index 8de96abe9da1..e75b142a1368 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -14,9 +14,14 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - cdns,spi-r1p6
> -      - xlnx,zynq-spi-r1p6
> +    oneOf:
> +      - enum:
> +          - cdns,spi-r1p6
> +          - xlnx,zynq-spi-r1p6
> +      - items:
> +          - enum:
> +              - cix,sky1-spi-r1p6
> +          - const: cdns,spi-r1p6

This doesn't apply, probably needs a rebase on spi/for-next?
Approach is correct though, but it'll be a more minimal patch when
rebased.
pw-bot: changes-requested

>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-10-27 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27  8:42 [PATCH v2 0/3] spi-cadence: support transmission with bits_per_word of 16 and 32 Jun Guo
2025-10-27  8:42 ` [PATCH v2 1/3] arm64: dts: cix: add a compatible string for the cix sky1 SoC Jun Guo
2025-10-27  8:42 ` [PATCH v2 2/3] dt-bindings: spi: spi-cadence: update DT binding docs to support " Jun Guo
2025-10-27 16:51   ` Conor Dooley [this message]
2025-10-28  2:54     ` Jun Guo
2025-10-27  8:42 ` [PATCH v2 3/3] spi: spi-cadence: supports transmission with bits_per_word of 16 and 32 Jun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251027-strangely-reverence-6f47d87efca5@spud \
    --to=conor@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=jun.guo@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=peter.chen@cixtech.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).