Re: [PATCH v1 2/7] spi: microchip-core: Make use of device properties

Andy Shevchenko
2025-11-26T16:27:19Z

On Wed, Nov 26, 2025 at 12:03:40PM +0000, Mark Brown wrote:
> On Wed, Nov 26, 2025 at 08:35:10AM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 25, 2025 at 11:19:22PM +0000, Mark Brown wrote:
>
> > > I really don't think it's a good idea to just do it as a thoughtless
> > > default given that there are cases where we actively want a different
> > > interface on ACPI or don't want to see a device used at all.
>
> > Okay,I think the commit message is a bit misleading. There are two ideas behind
> > this change, one is to have agnostic APIs in use, second one to make code
> > shorter and cleaner. Assuming we are targeting the second one as a main point,
> > does this make sense?

> I'm still a bit dubious TBH, I didn't spot anything super obvious in the
> patch and there's the whole should you actually use anything other than
> DT question still.

The only helpful API which has no par on DT side is matching strings.
Otherwise it's only about shorten lines and less LoCs.

> It'd seem better to make the OF APIs better if
> there's some big win there.

I dropped it in v2. Can that be applied instead?

--
With Best Regards,
Andy Shevchenko