From: Frank Li <Frank.Li@nxp.com>
To: Han Xu <han.xu@nxp.com>, Haibo Chen <haibo.chen@nxp.com>,
Mark Brown <broonie@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Frank Li <frank.li@nxp.com>,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, Felix Gu <ustc.gu@gmail.com>
Subject: Re: [PATCH v2 3/3] spi: fsl-qspi: Use reinit_completion() for repeated operations
Date: Wed, 4 Mar 2026 09:55:36 -0500 [thread overview]
Message-ID: <20260304145540.3331304-2-Frank.Li@nxp.com> (raw)
In-Reply-To: <20260304-spi-nxp-v2-3-cd7d7726a27e@gmail.com>
From: Frank Li (AI-BOT) <frank.li@nxp.com>
Commit message has a typo:
> Tchnically it may work, but it's not the recommended pattern.
Should be "Technically".
Also, the placement of init_completion() in the probe function should come
before devm_request_irq(), since the IRQ handler may reference the
completion object. The current placement is correct, but consider adding a
comment explaining why the initialization must happen before IRQ
registration.
Otherwise the patch looks good.
AI bot review and may be useless.
next prev parent reply other threads:[~2026-03-04 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 12:47 [PATCH v2 0/3] spi: nxp: Use reinit_completion() for repeated operations Felix Gu
2026-03-04 12:47 ` [PATCH v2 1/3] spi: nxp-xspi: " Felix Gu
2026-03-04 14:55 ` Frank Li
2026-03-05 0:13 ` Han Xu
2026-03-04 12:47 ` [PATCH v2 2/3] spi: nxp-fspi: " Felix Gu
2026-03-05 4:17 ` Hillf Danton
2026-03-09 2:23 ` Bough Chen
2026-03-04 12:47 ` [PATCH v2 3/3] spi: fsl-qspi: " Felix Gu
2026-03-04 14:55 ` Frank Li [this message]
2026-03-09 2:23 ` Bough Chen
2026-03-09 23:22 ` [PATCH v2 0/3] spi: nxp: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304145540.3331304-2-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ustc.gu@gmail.com \
--cc=yogeshgaur.83@gmail.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox