From: Rustam Adilov <adilov@disroot.org>
To: Mark Brown <broonie@kernel.org>, Bert Vermeulen <bert@biot.com>,
Birger Koblitz <mail@birger-koblitz.de>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rustam Adilov <adilov@disroot.org>,
Carlo Szelinsky <github@szelinsky.de>
Subject: [PATCH] spi: realtek-rtl: change to __raw reads and writes
Date: Sat, 11 Jul 2026 13:34:11 +0500 [thread overview]
Message-ID: <20260711083411.45836-1-adilov@disroot.org> (raw)
To make the spi driver operable with SWAP_IO_SPACE config
enabled, replace all instances of readl/writel with their
__raw variants. Otherwise readl/writel will do a byte swap
which this driver does not intend to do.
Tested-by: Carlo Szelinsky <github@szelinsky.de>
Signed-off-by: Rustam Adilov <adilov@disroot.org>
---
drivers/spi/spi-realtek-rtl.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/spi-realtek-rtl.c b/drivers/spi/spi-realtek-rtl.c
index 73065c8934dc..e1c40ff2e49d 100644
--- a/drivers/spi/spi-realtek-rtl.c
+++ b/drivers/spi/spi-realtek-rtl.c
@@ -35,58 +35,58 @@ static void rt_set_cs(struct spi_device *spi, bool active)
u32 value;
/* CS0 bit is active low */
- value = readl(REG(RTL_SPI_SFCSR));
+ value = __raw_readl(REG(RTL_SPI_SFCSR));
if (active)
value |= RTL_SPI_SFCSR_CSB0;
else
value &= ~RTL_SPI_SFCSR_CSB0;
- writel(value, REG(RTL_SPI_SFCSR));
+ __raw_writel(value, REG(RTL_SPI_SFCSR));
}
static void set_size(struct rtspi *rtspi, int size)
{
u32 value;
- value = readl(REG(RTL_SPI_SFCSR));
+ value = __raw_readl(REG(RTL_SPI_SFCSR));
value &= RTL_SPI_SFCSR_LEN_MASK;
if (size == 4)
value |= RTL_SPI_SFCSR_LEN4;
else if (size == 1)
value |= RTL_SPI_SFCSR_LEN1;
- writel(value, REG(RTL_SPI_SFCSR));
+ __raw_writel(value, REG(RTL_SPI_SFCSR));
}
static inline void wait_ready(struct rtspi *rtspi)
{
- while (!(readl(REG(RTL_SPI_SFCSR)) & RTL_SPI_SFCSR_RDY))
+ while (!(__raw_readl(REG(RTL_SPI_SFCSR)) & RTL_SPI_SFCSR_RDY))
cpu_relax();
}
static void send4(struct rtspi *rtspi, const u32 *buf)
{
wait_ready(rtspi);
set_size(rtspi, 4);
- writel(*buf, REG(RTL_SPI_SFDR));
+ __raw_writel(*buf, REG(RTL_SPI_SFDR));
}
static void send1(struct rtspi *rtspi, const u8 *buf)
{
wait_ready(rtspi);
set_size(rtspi, 1);
- writel(buf[0] << 24, REG(RTL_SPI_SFDR));
+ __raw_writel(buf[0] << 24, REG(RTL_SPI_SFDR));
}
static void rcv4(struct rtspi *rtspi, u32 *buf)
{
wait_ready(rtspi);
set_size(rtspi, 4);
- *buf = readl(REG(RTL_SPI_SFDR));
+ *buf = __raw_readl(REG(RTL_SPI_SFDR));
}
static void rcv1(struct rtspi *rtspi, u8 *buf)
{
wait_ready(rtspi);
set_size(rtspi, 1);
- *buf = readl(REG(RTL_SPI_SFDR)) >> 24;
+ *buf = __raw_readl(REG(RTL_SPI_SFDR)) >> 24;
}
static int transfer_one(struct spi_controller *ctrl, struct spi_device *spi,
@@ -134,16 +134,16 @@ static void init_hw(struct rtspi *rtspi)
u32 value;
/* Turn on big-endian byte ordering */
- value = readl(REG(RTL_SPI_SFCR));
+ value = __raw_readl(REG(RTL_SPI_SFCR));
value |= RTL_SPI_SFCR_RBO | RTL_SPI_SFCR_WBO;
- writel(value, REG(RTL_SPI_SFCR));
+ __raw_writel(value, REG(RTL_SPI_SFCR));
- value = readl(REG(RTL_SPI_SFCSR));
+ value = __raw_readl(REG(RTL_SPI_SFCSR));
/* Permanently disable CS1, since it's never used */
value |= RTL_SPI_SFCSR_CSB1;
/* Select CS0 for use */
value &= RTL_SPI_SFCSR_CS;
- writel(value, REG(RTL_SPI_SFCSR));
+ __raw_writel(value, REG(RTL_SPI_SFCSR));
}
static int realtek_rtl_spi_probe(struct platform_device *pdev)
--
2.55.0
next reply other threads:[~2026-07-11 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 8:34 Rustam Adilov [this message]
2026-07-16 13:00 ` [PATCH] spi: realtek-rtl: change to __raw reads and writes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260711083411.45836-1-adilov@disroot.org \
--to=adilov@disroot.org \
--cc=bert@biot.com \
--cc=broonie@kernel.org \
--cc=github@szelinsky.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mail@birger-koblitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox