From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D8430E853 for ; Sat, 11 Jul 2026 11:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783770600; cv=none; b=C5nBEVp0DkxPBnduO0Tl8QWI519Zzo9EKD7U7eCIE8Y6yrgdSvwCuAjH4rla4pvEG0Y0RxDzN67bu5fp8EkUOxDR3an88eRh9dsu9XZ6jqkFXrW6tTk4KyJoSXK69n3llI8SrGIdtToFql7LietXQgzyFVRvcbHwqY5Hb6mQsks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783770600; c=relaxed/simple; bh=Ywx0xSaBfiyT+DYliXVShFmq1Z788TCNlfdv+ynHru4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FGYBvGWkL3I4DIvWjsnsE5EWXZN4FewuXnYxJhMvUTHHIqViERJBQJBsNmatfgjdYpA3EgpAORX/3rwENvQ49aVUzAwu7gsKZCQeGAsK2/mjROgINxKW4DqVAxNas1rG5Qv1evAzFdy8DmiW5aI3x3NYBU1rzDB+Inf7LGUwDX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so1541482a91.2 for ; Sat, 11 Jul 2026 04:49:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783770598; x=1784375398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lKrCfY1VHLhMvkhcd76jeSHgip0JtyyrN3VT+vcLICs=; b=gOgM1pqdCopbsqOcd717EXSGABIfIkj327B2AKZ68or4PxVUm9Faa98DTbMivB2xgM 2cEmsqBL2dL/JUtedadVk8WyW6O6dBJITdl5+Q0uXfzM0Mnl37zjCmH/D/8b4FYg8T50 6wHuH39IwfcHVV6TegZAPOHh7O+GictaziJI0QO7qX8PIwIuYDhDm+dNOfqmdACtUCcb y9AiE+lskOr5B7F2OR8vn1xgMl5CYMp5Kjnvan8I2p+iJvYFtANy6Is7cldh54IgRsJQ aJpCpbIJCiky5ri1g9vcOwof+sZmLZlJIc8ZhGzRh3ECBg4POALaSteqOzagZRM0WC4j XvpA== X-Forwarded-Encrypted: i=1; AHgh+RqCYEnN0OcP0Z1JMbRSUFAqXMDbOkQy1fGV7oTeo3nyS7jOkwQTq86lccRCUqwi4yBUsVsG366Tla8=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ/QUqKkWnp9KrCVbOHwcatGqLL5Eo8WmYQAUeh+8DFwm4GtvH sS7/fPgaahTCitZ2v4fm4f1NxuULRdJU8PqGLawkQ1xVIcSGCcQekog= X-Gm-Gg: AfdE7cn7O+wJSz0qHQdGDj/bXrRmOO0J0ywE530PH7CrypbaVRxAgcjM+NqB0VacZzM 827dfUfMJNQcxmL+Pr/D7/oDvi6DpYfhAUU+ciTYiHKkM/1uJ4mNB9ddnUaWOC8qw4RVxPQ/Ql7 10z71HeOavfBeBqo0XSdu6fN+yLjgiDCv/qYdksttvLcZ5QcZcvbm2cdOlX57aqs40S8sbhnec3 2HIobP7a7D5k8CqgZw2ecqK7dzhnswlqXl8qCE6TtFeMV5DAhhOn0Opf6zu5hnF9wO0/cY693iO GJWA0gddGMaEacXLXbg9mLORZWiIx9bNWzs562S3R1yK60CdjFxlIQm3E6khOw0XdNhsI7lurG7 EbPpB5KkDlyGgnPejQGgMiBRkxSQ4INgtS/tDYiOMvmE67dhFzSnttngd2esCkZmROVC3RjPb8a nFKhBrpEJKcgXX3X3UZY3tIBjevBPP8A2mvPv7fvDrrF0Rz1TaqEKAFnuWVLECrrqq3Yk2XEb9V d3Dl53EteL8v1RO+HCXD6cek1ZTVCvxWqUh X-Received: by 2002:a17:90b:1644:b0:387:e0db:bc2d with SMTP id 98e67ed59e1d1-38dc7ba5a7emr2604450a91.35.1783770598497; Sat, 11 Jul 2026 04:49:58 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-52-13.dynamic-ip.hinet.net. [61.228.52.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5506b48bsm3957570a91.1.2026.07.11.04.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 04:49:58 -0700 (PDT) From: Shih-Yuan Lee To: Dmitry Torokhov , Mark Brown Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shih-Yuan Lee , linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 0/3] Input/SPI: fixes for MacBook8,1 DMA timeout, UAF, and NULL pointer dereference Date: Sat, 11 Jul 2026 19:49:34 +0800 Message-Id: <20260711114937.16670-1-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260711055247.5412-1-fourdollars@debian.org> References: <20260711055247.5412-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dmitry, Mark, and the linux-input/linux-spi community, This patch series addresses a long-standing DMA initialization timeout on the early 2015 12" MacBook (MacBook8,1) on any boot (including cold boot), as well as two pre-existing, high-severity UAF/NULL-pointer bugs in the applespi driver. Changes in v4: - Reverted the runtime `can_dma` callback override from `applespi.c` to avoid architectural layering violation, data races (TOCTOU) with concurrent SPI transfers, and execute-after-free vulnerability upon module unload. - Moved the DMI quirk forcing PIO mode for MacBook8,1 to the host PCI glue driver (spi-pxa2xx-pci.c) where LPSS setup occurs. - Formatted the DMI match using a structured `pxa2xx_spi_pci_dmi_table` and helper function `pxa2xx_spi_pci_can_dma()`. - Added a `force_pio` module parameter in spi-pxa2xx-pci.c to allow other users to manually force PIO mode for debugging. Changes in v3: - Added a `force_pio` module parameter to applespi to allow users to manually disable DMA for SPI transfers. - Resolved the execute-after-free vulnerability by unconditionally restoring the original can_dma callback (even if NULL) in the driver remove path. - Fixed the probe timing issue by applying the can_dma override at the very beginning of applespi_probe() so that all early initialization transfers safely use PIO mode, and properly restoring it in all probe error paths. - Documented the Bugzilla link in the commit message of Patch 1. Changes in v2: - Fixed an unbind/remove execute-after-free vulnerability by storing and restoring the host controller's original can_dma callback in applespi_probe() and applespi_remove(). - Split the fixes into a 3-patch logical series. Patch 1 fixes a pre-existing UAF vulnerability in the driver unbind path by explicitly calling cancel_work_sync() on the asynchronous registration worker work struct before devres frees the driver private data. Patch 2 fixes a pre-existing race condition in the debugfs interface where userspace could open the tp_dim file before the asynchronous worker has finished initializing applespi->touchpad_input_dev, leading to a NULL pointer dereference. We resolve this using smp_load_acquire() and checking for NULL. Patch 3 introduces a structured DMI quirk and a `force_pio` module parameter in spi-pxa2xx-pci.c to disable DMA on MacBook8,1. This forces the controller to use the rock-solid PIO mode from the very beginning. Best regards, Shih-Yuan Lee Shih-Yuan Lee (3): Input: applespi - cancel pending work on driver remove Input: applespi - fix NULL pointer dereference in tp_dim open spi: pxa2xx: disable DMA for Apple MacBook8,1 drivers/input/keyboard/applespi.c | 10 +++++++++- drivers/spi/spi-pxa2xx-pci.c | 33 ++++++++++++++++++++++++++++++- 2 files changed, 41 insertions(+), 2 deletions(-) -- 2.39.5